perf: use cpu cores more efficently #705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 28bdc6d 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6202c7b079147500087fb0e3 😎 Browse the preview: https://deploy-preview-705--vitest-dev.netlify.app |
patak-dev
approved these changes
Feb 8, 2022
|
What Ive observed with Jest is that using Might worth trying. Maybe vitest has similar sweet spot somewhere lower than CPU cores - 1. |
|
@vlazar Thanks for the info, I will check this out. We still have a lot of performance work to do. |
chaii3
pushed a commit
to chaii3/vitest
that referenced
this pull request
May 13, 2022
) * feat(useWebSocket): ✨ Added support for optional protocols parameter Added support for an optional array parameter called protocols. This second parameter to the WebSocket constructor contains one or more protocol string to use e.g. subprotocols. If not provided, internally the parameter always default to an empty array (`[]`), so that was chosen as parameter initializer. More information can be found (here)[https://developer.mozilla.org/en-US/docs/Web/API/WebSocket/WebSocket]. * refactor(useWebSockets): Moved protocols option to WebSocketOptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made adjustments to number of threads created. Vitest now uses more threads by default.
Implementation is just like in Jest:
minThreadsis the same asmaxThreadsfor now because of tinylibs/tinypool#23. This will cause a really small slowdown if number of test files is less than number of CPU cores. When Tinypool is fixed to better handleminThreadsandmaxThreadsin isolate modeminThreadscan be adjusted.This improved performance of https://github.com/EvHaus/jest-vs-jasmine tests suite by 30% on my machine (16 cores)