Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed typescript error when calling assertion #709

Merged
merged 6 commits into from Feb 9, 2022

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Feb 9, 2022

Fixes #707

This originally comes from:

    interface TypeComparison {
        (type: string, message?: string): Assertion;
        instanceof: InstanceOf;
        instanceOf: InstanceOf;
    }

But we are overriding it, so

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for vitest-dev ready!

🔨 Explore the source changes: cb7695c

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/62035cd2c2f7830007235707

😎 Browse the preview: https://deploy-preview-709--vitest-dev.netlify.app

@sheremet-va sheremet-va marked this pull request as draft February 9, 2022 06:11
@sheremet-va sheremet-va marked this pull request as ready for review February 9, 2022 06:19
@antfu antfu merged commit 4aa09c8 into main Feb 9, 2022
@antfu antfu deleted the sheremet-va/fix-types branch February 9, 2022 13:43
chaii3 pushed a commit to chaii3/vitest that referenced this pull request May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Typescript error with "to.be.a"
2 participants