Watch mode behaviour can't be override from CLI

[ShivamJoker]

Describe the bug

Watch mode behaviour can't be override by passing flags from CLI

Reproduction

Create a basic test app from docs

Disable watch mode in config

/// <reference types="vitest" />
import { defineConfig } from "vite";

export default defineConfig({
  test: {
    watch: false,
  },
});

Try running watch mode from CLI

npx vitest watch

or

npx vitest --watch

Screenshots 👇

System Info

System:
    OS: macOS 12.1
    CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
    Memory: 275.97 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 17.4.0 - /usr/local/bin/node
    Yarn: 1.22.17 - /usr/local/bin/yarn
    npm: 8.4.1 - /usr/local/bin/npm
  Browsers:
    Chrome: 98.0.4758.80
    Safari: 15.2
  npmPackages:
    vitest: ^0.2.7 => 0.2.7

Used Package Manager

yarn

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[DerYeger]

I had a look at the source code and the config file is supposed to override the CLI args.

vitest/packages/vitest/src/node/plugins/index.ts

Line 48 in 3df5d8b

options = deepMerge(options, viteConfig.test as any || {})

Do you need so set watch to false in the config?
You could just disable watch mode by using vitest run when required.

[ShivamJoker]

Ohh the CLI should override it. And by default watch is enabled #696 (I sent PR for this)

[DerYeger]

Ohh the CLI should override it by default watch is enabled #696 (I sent PR for this)

I'm not sure what you mean.
The default is !process.env.CI && !argv.run.
This is overridden by the CLI, which in return is overridden by the config.

[ShivamJoker]

@DerYeger thats what I am trying to say by default the watch is enabled, and to disable it I set the watch to false in config file.
But I want to enable watch from the CLI flag, How do I do it?

[DerYeger]

You can't.
Remove the watch: false and use vitest run instead of vitest.
If you want watch mode enabled, use vitest or even vitest run --watch.

[ShivamJoker]

okay it works that way.

But I believe CLI should override the default config no matter what 🙅

[Demivan]

I agree with @ShivamJoker here. CLI args should override config.
I was using threads: true in config and --no-threads CLI arg was working just fine.

[DerYeger]

Will be closed by #702

[ShivamJoker]

@DerYeger so now it's fixed?

[DerYeger]

Yes, as part of v0.3.0.

…

On 09.02.2022, at 15:57, Shivam ***@***.***> wrote: @DerYeger <https://github.com/DerYeger> so now it's fixed? — Reply to this email directly, view it on GitHub <#710 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4U6DRQJ5LBNVMFQITOFHDU2J6ETANCNFSM5N4U4ISQ>. You are receiving this because you were mentioned.

[sheremet-va]

There is now an issue: vitest run enables watch mode (#713 (comment))