fix: default reporters should be an array #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes vitest-dev#718 This fixes the error `TypeError: target[key].push is not a function` that occurs when a config is defined with reporters. This is because the deepMerge function tries to merge the given array of reporters with the default config, which is the string `"default"`. By fixing the default config to be an array of reporters, only containing the default one, the issue is fixed.
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 628d770 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6203dc1ac30cc30007df9f98 😎 Browse the preview: https://deploy-preview-720--vitest-dev.netlify.app |
chaii3
pushed a commit
to chaii3/vitest
that referenced
this pull request
May 13, 2022
Co-authored-by: LinusBorg <LinusBorg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #718
This fixes the error
TypeError: target[key].push is not a functionthat occurs when a config is defined with reporters.This is because the deepMerge function tries to merge the given array of reporters with the default config, which is the string
"default".By fixing the default config to be an array of reporters, only containing the default one, the issue is fixed.