fix(cli): allow user to override reporter via cli option #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: fcb5c58 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6204236fb6e810000827a150 😎 Browse the preview: https://deploy-preview-721--vitest-dev.netlify.app |
11joselu
changed the title
patak-dev
reviewed
Feb 9, 2022
| @@ -61,9 +61,10 @@ export class Vitest { | |||
| this.state = new StateManager() | |||
| this.snapshot = new SnapshotManager(resolved) | |||
| // @ts-expect-error cli type | |||
| this.reporters = toArray(resolved.reporters || resolved.reporter) | |||
| this.reporters = toArray(resolved.reporter || resolved.reporters) | |||
There was a problem hiding this comment.
Shouldn't we directly use resolved.reporters here and overwrite it with reporter inside resolveConfig?
There was a problem hiding this comment.
There are (I think) 3 possibles solution)
- current propossal
- your propossal solution (makes sense to me too)
- rename cli option from reporter to reporters (because with this change fix: default reporters should be an array #720 reporters could be now an array of reporters (make sense that?))
What is the best solution here?
There was a problem hiding this comment.
We should keep the default of the reporters option empty and resolve them in resolveConfig. When the array is empty, append default to it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think after this changes #702 we are not able to override vitest reporter via cli options. Always use
defaultTo test it