Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config watch is overridden by default value #724

Closed
6 tasks done
DerYeger opened this issue Feb 10, 2022 · 0 comments
Closed
6 tasks done

Config watch is overridden by default value #724

DerYeger opened this issue Feb 10, 2022 · 0 comments

Comments

@DerYeger
Copy link
Member

Describe the bug

The fix added in 837711d does not work properly.
Adding watch: false to the config and running vitest will enter watch mode, since the default value is set at the user options level, which overwrites the test config.

We have to set the default value outside the user options (in the defaults) as done in #717.

Reproduction

  1. Add watch: false to the test config.
  2. Run vitest.

Can be reproduced in the Vitest repo.

System Info

System:
    OS: macOS 12.1
    CPU: (8) arm64 Apple M1
    Memory: 194.22 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.2 - ~/.volta/tools/image/node/16.13.2/bin/node
    Yarn: 1.22.17 - ~/.volta/tools/image/yarn/1.22.17/bin/yarn
    npm: 8.1.2 - ~/.volta/tools/image/node/16.13.2/bin/npm
  Browsers:
    Chrome: 98.0.4758.80
    Safari: 15.2
  npmPackages:
    vite: ^2.7.13 => 2.7.13 
    vitest: workspace:* => 0.3.1

Used Package Manager

pnpm

Validations

@antfu antfu closed this as completed in 6772c5f Feb 10, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant