Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config watch: false requires --no-run to be overridden #727

Closed
6 tasks done
DerYeger opened this issue Feb 10, 2022 · 2 comments
Closed
6 tasks done

Config watch: false requires --no-run to be overridden #727

DerYeger opened this issue Feb 10, 2022 · 2 comments

Comments

@DerYeger
Copy link
Member

Describe the bug

After 6772c5fa5ebf5eb0d101c64247e0bd9ecffcac87, watch mode can no longer be enabled by passing the --watch flag if watch has been set to false in the config.

To use watch mode, the --no-run flag has to be passed in addition.

Reproduction

  1. Add watch: false to the config.
  2. Run vitest --watch.

System Info

System:
    OS: macOS 12.1
    CPU: (8) arm64 Apple M1
    Memory: 194.22 MB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.13.2 - ~/.volta/tools/image/node/16.13.2/bin/node
    Yarn: 1.22.17 - ~/.volta/tools/image/yarn/1.22.17/bin/yarn
    npm: 8.1.2 - ~/.volta/tools/image/node/16.13.2/bin/npm
  Browsers:
    Chrome: 98.0.4758.80
    Safari: 15.2
  npmPackages:
    vite: ^2.7.13 => 2.7.13 
    vitest: workspace:* => 0.3.1

Used Package Manager

pnpm

Validations

@DerYeger DerYeger changed the title Config watch can no longer be override Config watch can no longer be overridden Feb 10, 2022
@DerYeger DerYeger changed the title Config watch can no longer be overridden Config watch requires --no-run to be overridden Feb 10, 2022
@DerYeger DerYeger changed the title Config watch requires --no-run to be overridden Config watch: false requires --no-run to be overridden Feb 10, 2022
@DerYeger DerYeger added the bug label Feb 10, 2022
@stygian-desolator
Copy link
Contributor

Perhaps options.run could be deprecated, it duplicates options.watch. 🤔

@Aslemammad
Copy link
Member

@DerYeger Hey, Please consider seeing #736 and see if it solves your problem! Thanks!

@antfu antfu closed this as completed Feb 12, 2022
chaii3 pushed a commit to chaii3/vitest that referenced this issue May 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants