feat: support readonly tuples as input to .each
#733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 9784b1a 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6206532b3d056800074f737a 😎 Browse the preview: https://deploy-preview-733--vitest-dev.netlify.app |
IgnusG
changed the title
Using readonly tuples makes it easy to type check their individual parts inside the test.
sheremet-va
approved these changes
Feb 11, 2022
|
I've added one test that would fail if the types get merged (const not used or respected). @sheremet-va let me know if that's alright or if it's not needed. |
antfu
approved these changes
Feb 11, 2022
antfu
changed the title
.each
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using readonly tuples makes it easy to type check their individual parts inside the test.
Resolves #732