feat: support BigInt for jest assertions #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: dd68bf9 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/6208e69ccf19f800073241b6 😎 Browse the preview: https://deploy-preview-742--vitest-dev.netlify.app |
antfu
changed the title
antfu
changed the title
sheremet-va
requested changes
Feb 12, 2022
| def('toBeGreaterThan', function(expected: number | bigint) { | ||
| const actual = this._obj | ||
| if (typeof actual !== 'number' && typeof actual !== 'bigint') { | ||
| return this.assert( |
There was a problem hiding this comment.
Not sure about this use of assert
It's not actually an AssertionError, since no assertion was actually performed bc the input was wrong. Maybe we can
- Throw TypeError
- Move it to some helper function to reuse in other assertions
- Rewrite to something like:
assertTypes(expected, 'expected', ['number', 'bigint'])
assertTypes(actual, 'received', ['number', 'bigint']) // throws Recieved values must be type or type, received "type"There was a problem hiding this comment.
Display the message like this when a type error occurred.
sheremet-va
approved these changes
Feb 13, 2022
patak-dev
reviewed
Feb 13, 2022
packages/vitest/src/index.ts
Outdated
Comment on lines
89
to
90
| toBeLessThan(num: number): void | ||
| toBeLessThanOrEqual(num: number): void |
There was a problem hiding this comment.
Great PR! toBeLessThan and toBeLessThanOrEqual should also be number | bigint. Would you like to modify them as part of this PR?
patak-dev
approved these changes
Feb 13, 2022
chaii3
pushed a commit
to chaii3/vitest
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
toBeGreaterThanandtoBeGreaterThanOrEqualsupport forBigInt, which was added in ES2020 to follow jest.https://jestjs.io/docs/expect#tobegreaterthannumber--bigint