Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow reassigning define globals #769

Merged
merged 5 commits into from Feb 18, 2022
Merged

feat: allow reassigning define globals #769

merged 5 commits into from Feb 18, 2022

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Feb 16, 2022

Depends on vitejs/vite#6935 (review) (actually, everything works except reassigning NODE_ENV)

@netlify
Copy link

netlify bot commented Feb 16, 2022

✔️ Deploy Preview for vitest-dev ready!

🔨 Explore the source changes: f44af43

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/620e17e891ec3d000751aa4e

😎 Browse the preview: https://deploy-preview-769--vitest-dev.netlify.app

@sheremet-va sheremet-va marked this pull request as draft February 16, 2022 17:44
@sheremet-va sheremet-va marked this pull request as ready for review February 17, 2022 09:38
@antfu antfu merged commit 15ea3a3 into main Feb 18, 2022
@antfu antfu deleted the sheremet-va/define branch February 18, 2022 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants