New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow changing name pattern during watch mode #819
Conversation
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 5751c9e 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/62126b18e9c76c0008ea107a 😎 Browse the preview: https://deploy-preview-819--vitest-dev.netlify.app |
About the wording, Jest uses "Press t to filter by a test name regex pattern.". Maybe we could also expand it to "Change test name pattern"? The |
Looks good now! And I can type. But if I press backspace it writes "backspace" and if I tried to use uppercase it doesn't let me. I was trying to write "JSON" to filter that one. |
Should be fixed 😃 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
One thing about DX, maybe we shouldn't show the skipped tests when using this option, because if there are a lot of them you don't see the ones that were filtered (for example with JSON in the core tests)
I agree, but this is more about |
Closes #658