feat: vite-node watch mode #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 686093a 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/62326c639f698e0009e0b32d 😎 Browse the preview: https://deploy-preview-890--vitest-dev.netlify.app |
|
When will this be release? Is there a way for me to use it now? Eager to try this out! |
poyoho
commented
Mar 5, 2022
I think I need to improve the update process |
antfu
reviewed
Mar 7, 2022
packages/vite-node/src/cli.ts
Outdated
| console.log(dim(`[update] ${path}`)) | ||
| // because module don't had `import.meta.hot.accept` | ||
| // only can refresh all module | ||
| runner.moduleCache.clear() |
There was a problem hiding this comment.
I think at least we should keep the cache of node_modules.
|
@antfu Should we add unit tests in the test directory for vite-node? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #889
don't close server when watch mode is open.And delete the moduleCache when the module refresh.