Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add perfStats to json reporter #933

Merged
merged 6 commits into from Mar 13, 2022
Merged

feat: add perfStats to json reporter #933

merged 6 commits into from Mar 13, 2022

Conversation

zxch3n
Copy link
Member

@zxch3n zxch3n commented Mar 13, 2022

Add the missing field perfStats to JSON TestResult compared to Jest test result type.

{  
  ...
  perfStats: {
    end?: Milliseconds
    runtime?: Milliseconds
    start?: Milliseconds
  },
  ...
}

@netlify
Copy link

netlify bot commented Mar 13, 2022 •
edited

✔️ Deploy Preview for vitest-dev ready!

🔨 Explore the source changes: 7a45ae5

🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/622db5797c19900008e19fa3

😎 Browse the preview: https://deploy-preview-933--vitest-dev.netlify.app

@sheremet-va
Copy link
Member

What about slow? Also can we make a snapshot of JSON instead of a string here? 👀

@zxch3n
Copy link
Member Author

zxch3n commented Mar 13, 2022

slow would require additional project config, like jest's slowTestThreshold [number].

sheremet-va
sheremet-va approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@sheremet-va sheremet-va left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antfu antfu merged commit 89c8421 into vitest-dev:main Mar 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dammy001 dammy001 dammy001 left review comments

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zxch3n @sheremet-va @dammy001 @antfu