feat(ui): open in IDE tests with error on report and code tabs #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for vitest-dev ready! 🔨 Explore the source changes: 6a91bf8 🔍 Inspect the deploy log: https://app.netlify.com/sites/vitest-dev/deploys/62371e8940b80300084297f5 😎 Browse the preview: https://deploy-preview-992--vitest-dev.netlify.app |
|
maybe we can also include it on the editor tab, testing... |
dammy001
reviewed
Mar 20, 2022
| @@ -36,7 +43,16 @@ function relative(p: string) { | |||
| {{ task.name }} | |||
| <div v-if="task.result?.error" class="scrolls scrolls-rounded task-error"> | |||
| <pre><b>{{ task.result.error.name || task.result.error.nameStr }}</b>: {{ task.result.error.message }}</pre> | |||
| <pre v-for="stack, i of task.result.error.stacks || []" :key="i" op80> - {{ relative(stack.file) }}:{{ stack.line }}:{{ stack.column }}</pre> | |||
| <div v-for="(stack, i) of task.result.error.stacks || []" :key="i" class="op80 flex gap-x-2 items-center"> | |||
There was a problem hiding this comment.
Why not destructure the stack?
There was a problem hiding this comment.
ok
trying also adding on code tab
|
working also on code editor
|
userquin
changed the title
userquin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added link and icon only for matching
props.file.name, the following capture not showing the editor, I cannot capture 2 windows on Windows, I'm usingIntelliJ EEand opening the corresponding file (it seems 2 lines above on the error line):https://streamable.com/x9ihm5
EDIT: the mouse over also not showing
Open in IDEtitle on span with the icon.closes #988