From 773cbd78c7b18480b1328de1251af0b3db4d0923 Mon Sep 17 00:00:00 2001
From: Vladimir Sheremet <sheremet.va@icloud.com>
Date: Mon, 20 Jun 2022 08:05:11 +0300
Subject: [PATCH 1/2] fix: return types for vi.mocked are now equal to
 MaybeMocked

---
 packages/vitest/src/integrations/spy.ts | 10 ++--------
 test/core/test/vi.spec.ts               | 12 +++++++++++-
 2 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/packages/vitest/src/integrations/spy.ts b/packages/vitest/src/integrations/spy.ts
index 076d70e649bb..99191f66c230 100644
--- a/packages/vitest/src/integrations/spy.ts
+++ b/packages/vitest/src/integrations/spy.ts
@@ -67,10 +67,10 @@ export type MaybeMockedConstructor<T> = T extends new (
 ) => infer R
   ? SpyInstanceFn<ConstructorParameters<T>, R>
   : T
-export type MockedFunction<T extends Procedure> = MockWithArgs<T> & {
+export type MockedFunction<T extends Procedure> = SpyInstanceFn<Parameters<T>, ReturnType<T>> & {
   [K in keyof T]: T[K];
 }
-export type MockedFunctionDeep<T extends Procedure> = MockWithArgs<T> & MockedObjectDeep<T>
+export type MockedFunctionDeep<T extends Procedure> = SpyInstanceFn<Parameters<T>, ReturnType<T>> & MockedObjectDeep<T>
 export type MockedObject<T> = MaybeMockedConstructor<T> & {
   [K in Methods<T>]: T[K] extends Procedure
     ? MockedFunction<T[K]>
@@ -96,12 +96,6 @@ export type MaybeMocked<T> = T extends Procedure
 
 export type EnhancedSpy<TArgs extends any[] = any[], TReturns = any> = SpyInstance<TArgs, TReturns> & SpyImpl<TArgs, TReturns>
 
-export interface MockWithArgs<T extends Procedure>
-  extends SpyInstanceFn<Parameters<T>, ReturnType<T>> {
-  new (...args: T extends new (...args: any) => any ? ConstructorParameters<T> : never): T
-  (...args: Parameters<T>): ReturnType<T>
-}
-
 export const spies = new Set<SpyInstance>()
 
 export function isMockFunction(fn: any): fn is EnhancedSpy {
diff --git a/test/core/test/vi.spec.ts b/test/core/test/vi.spec.ts
index ddd84545b166..f2fae11a0bc9 100644
--- a/test/core/test/vi.spec.ts
+++ b/test/core/test/vi.spec.ts
@@ -2,8 +2,11 @@
  * @vitest-environment jsdom
  */
 
+import type { MockedFunction, MockedObject } from 'vitest'
 import { describe, expect, test, vi } from 'vitest'
 
+const expectType = <T>(obj: T) => obj
+
 describe('testing vi utils', () => {
   test('global scope has variable', () => {
     const IntersectionObserverMock = vi.fn()
@@ -29,7 +32,14 @@ describe('testing vi utils', () => {
     expect(v1).toBe(v2)
   })
 
-  // TODO: it's unstable in CI, skip until resolved
+  test('vi mocked', () => {
+    expectType<MockedObject<{ bar: () => boolean }>>({
+      bar: vi.fn(() => true),
+    })
+    expectType<MockedFunction<() => boolean>>(vi.fn(() => true))
+    expectType<MockedFunction<() => boolean>>(vi.fn())
+  })
+
   test.skip('loads unloaded module', async () => {
     let mod: any
     import('../src/timeout').then(m => mod = m)

From 24e950cef892a56cf110ca47fc52272d7781a9bf Mon Sep 17 00:00:00 2001
From: Vladimir Sheremet <sheremet.va@icloud.com>
Date: Mon, 20 Jun 2022 08:05:49 +0300
Subject: [PATCH 2/2] chore: cleanup

---
 test/core/test/vi.spec.ts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/test/core/test/vi.spec.ts b/test/core/test/vi.spec.ts
index f2fae11a0bc9..63e03e540aa1 100644
--- a/test/core/test/vi.spec.ts
+++ b/test/core/test/vi.spec.ts
@@ -40,6 +40,7 @@ describe('testing vi utils', () => {
     expectType<MockedFunction<() => boolean>>(vi.fn())
   })
 
+  // TODO: it's unstable in CI, skip until resolved
   test.skip('loads unloaded module', async () => {
     let mod: any
     import('../src/timeout').then(m => mod = m)