From d32c47a0fbd97c47668738ffb36945ee9c110811 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 1 Mar 2024 09:02:33 +0900 Subject: [PATCH 1/8] ci: fix playwright (wip) --- wip.txt | 1 + 1 file changed, 1 insertion(+) create mode 100644 wip.txt diff --git a/wip.txt b/wip.txt new file mode 100644 index 000000000000..e7123041ee04 --- /dev/null +++ b/wip.txt @@ -0,0 +1 @@ +wip From 9ce3656a8712ce315dfcea0745c10be927df7885 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 1 Mar 2024 10:18:21 +0900 Subject: [PATCH 2/8] ci: debug --- .github/workflows/ci.yml | 290 ++++++++++++++++++++++----------------- 1 file changed, 164 insertions(+), 126 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 45d49aa08936..9b6385b899cd 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,50 +19,51 @@ env: CYPRESS_CACHE_FOLDER: ${{ github.workspace }}/.cache/Cypress jobs: - lint: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 + # lint: + # runs-on: ubuntu-latest + # steps: + # - uses: actions/checkout@v4 - - uses: ./.github/actions/setup-and-cache + # - uses: ./.github/actions/setup-and-cache - - name: Install - run: pnpm i + # - name: Install + # run: pnpm i - - name: Lint - run: pnpm run lint + # - name: Lint + # run: pnpm run lint - typecheck: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v4 + # typecheck: + # runs-on: ubuntu-latest + # steps: + # - uses: actions/checkout@v4 - - uses: ./.github/actions/setup-and-cache + # - uses: ./.github/actions/setup-and-cache - - name: Install - run: pnpm i + # - name: Install + # run: pnpm i - - name: Build - run: pnpm run build + # - name: Build + # run: pnpm run build - - name: Typecheck - run: pnpm run typecheck + # - name: Typecheck + # run: pnpm run typecheck - test: - runs-on: ${{ matrix.os }} + debug: + runs-on: ubuntu-latest + # runs-on: ${{ matrix.os }} - timeout-minutes: 30 + # timeout-minutes: 30 - strategy: - matrix: - os: [ubuntu-latest] - node_version: [18, 20] - include: - - os: macos-14 - node_version: 20 - - os: windows-latest - node_version: 20 - fail-fast: false + # strategy: + # matrix: + # os: [ubuntu-latest] + # node_version: [18, 20] + # include: + # - os: macos-14 + # node_version: 20 + # - os: windows-latest + # node_version: 20 + # fail-fast: false steps: - uses: actions/checkout@v4 @@ -83,133 +84,170 @@ jobs: run: pnpm run build - name: Test - run: pnpm run test:ci + run: pnpm -C examples/playwright test - - name: Test No Threads - run: pnpm run test:ci:no-threads + # test: + # runs-on: ${{ matrix.os }} - - name: Test Vm Threads - run: pnpm run test:ci:vm-threads + # timeout-minutes: 30 - test-ui: - runs-on: ubuntu-latest + # strategy: + # matrix: + # os: [ubuntu-latest] + # node_version: [18, 20] + # include: + # - os: macos-14 + # node_version: 20 + # - os: windows-latest + # node_version: 20 + # fail-fast: false - timeout-minutes: 10 + # steps: + # - uses: actions/checkout@v4 - steps: - - uses: actions/checkout@v4 + # - uses: ./.github/actions/setup-and-cache + # with: + # node-version: ${{ matrix.node_version }} - - uses: ./.github/actions/setup-and-cache - with: - node-version: 20 + # - uses: browser-actions/setup-chrome@v1 - - name: Install - run: pnpm i + # - name: Install + # run: pnpm i - - name: Test UI - run: pnpm run ui:test + # - name: Install Playwright Dependencies + # run: pnpx playwright install --with-deps - test-ui-e2e: - strategy: - matrix: - os: [ubuntu-latest, macos-14, windows-latest] - fail-fast: false + # - name: Build + # run: pnpm run build - runs-on: ${{ matrix.os }} + # - name: Test + # run: pnpm run test:ci - timeout-minutes: 30 + # - name: Test No Threads + # run: pnpm run test:ci:no-threads - steps: - - uses: actions/checkout@v4 + # - name: Test Vm Threads + # run: pnpm run test:ci:vm-threads - - uses: ./.github/actions/setup-and-cache - with: - node-version: 20 + # test-ui: + # runs-on: ubuntu-latest - - name: Install - run: pnpm i + # timeout-minutes: 10 - - name: Install Playwright Dependencies - run: pnpx playwright install chromium + # steps: + # - uses: actions/checkout@v4 - - name: Build - run: pnpm run build + # - uses: ./.github/actions/setup-and-cache + # with: + # node-version: 20 - - name: Test - run: pnpm -C test/ui test-e2e + # - name: Install + # run: pnpm i - test-browser: - runs-on: ubuntu-latest - strategy: - matrix: - browser: [[chrome, chromium], [firefox, firefox], [edge, webkit]] - fail-fast: false + # - name: Test UI + # run: pnpm run ui:test - timeout-minutes: 30 + # test-ui-e2e: + # strategy: + # matrix: + # os: [ubuntu-latest, macos-14, windows-latest] + # fail-fast: false - env: - BROWSER: ${{ matrix.browser[0] }} - steps: - - uses: actions/checkout@v4 + # runs-on: ${{ matrix.os }} - - uses: ./.github/actions/setup-and-cache - with: - node-version: 20 + # timeout-minutes: 30 - - uses: browser-actions/setup-chrome@v1 - - uses: browser-actions/setup-firefox@v1 + # steps: + # - uses: actions/checkout@v4 - - name: Install - run: pnpm i + # - uses: ./.github/actions/setup-and-cache + # with: + # node-version: 20 - - name: Install Playwright Dependencies - run: pnpx playwright install --with-deps + # - name: Install + # run: pnpm i - - name: Build - run: pnpm run build + # - name: Install Playwright Dependencies + # run: pnpx playwright install chromium - - name: Test Browser (webdriverio) - run: pnpm run test:browser:webdriverio + # - name: Build + # run: pnpm run build - - name: Test Browser (playwright) - run: pnpm run test:browser:playwright - env: - BROWSER: ${{ matrix.browser[1] }} + # - name: Test + # run: pnpm -C test/ui test-e2e - test-browser-windows: - runs-on: windows-latest - strategy: - matrix: - browser: [[chrome, chromium], [edge, webkit]] - fail-fast: false + # test-browser: + # runs-on: ubuntu-latest + # strategy: + # matrix: + # browser: [[chrome, chromium], [firefox, firefox], [edge, webkit]] + # fail-fast: false - timeout-minutes: 30 + # timeout-minutes: 30 - env: - BROWSER: ${{ matrix.browser[0] }} - steps: - - uses: actions/checkout@v4 + # env: + # BROWSER: ${{ matrix.browser[0] }} + # steps: + # - uses: actions/checkout@v4 - - uses: ./.github/actions/setup-and-cache - with: - node-version: 20 + # - uses: ./.github/actions/setup-and-cache + # with: + # node-version: 20 - - uses: browser-actions/setup-chrome@v1 - - uses: browser-actions/setup-edge@v1 + # - uses: browser-actions/setup-chrome@v1 + # - uses: browser-actions/setup-firefox@v1 - - name: Install - run: pnpm i + # - name: Install + # run: pnpm i - - name: Install Playwright Dependencies - run: pnpx playwright install --with-deps + # - name: Install Playwright Dependencies + # run: pnpx playwright install --with-deps - - name: Build - run: pnpm run build + # - name: Build + # run: pnpm run build + + # - name: Test Browser (webdriverio) + # run: pnpm run test:browser:webdriverio + + # - name: Test Browser (playwright) + # run: pnpm run test:browser:playwright + # env: + # BROWSER: ${{ matrix.browser[1] }} + + # test-browser-windows: + # runs-on: windows-latest + # strategy: + # matrix: + # browser: [[chrome, chromium], [edge, webkit]] + # fail-fast: false + + # timeout-minutes: 30 + + # env: + # BROWSER: ${{ matrix.browser[0] }} + # steps: + # - uses: actions/checkout@v4 + + # - uses: ./.github/actions/setup-and-cache + # with: + # node-version: 20 + + # - uses: browser-actions/setup-chrome@v1 + # - uses: browser-actions/setup-edge@v1 + + # - name: Install + # run: pnpm i + + # - name: Install Playwright Dependencies + # run: pnpx playwright install --with-deps + + # - name: Build + # run: pnpm run build - - name: Test Browser (webdriverio) - run: pnpm run test:browser:webdriverio + # - name: Test Browser (webdriverio) + # run: pnpm run test:browser:webdriverio - - name: Test Browser (playwright) - run: pnpm run test:browser:playwright - env: - BROWSER: ${{ matrix.browser[1] }} + # - name: Test Browser (playwright) + # run: pnpm run test:browser:playwright + # env: + # BROWSER: ${{ matrix.browser[1] }} From f9c03dd688a3e634963c6258f0d18d7ffa8fd30d Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 1 Mar 2024 10:23:37 +0900 Subject: [PATCH 3/8] ci: debug 2 --- .github/workflows/ci.yml | 8 +++---- pnpm-lock.yaml | 52 ++++++++++++++++++++-------------------- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9b6385b899cd..2b0b33350a56 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -68,11 +68,11 @@ jobs: steps: - uses: actions/checkout@v4 - - uses: ./.github/actions/setup-and-cache - with: - node-version: ${{ matrix.node_version }} + # - uses: ./.github/actions/setup-and-cache + # with: + # node-version: ${{ matrix.node_version }} - - uses: browser-actions/setup-chrome@v1 + # - uses: browser-actions/setup-chrome@v1 - name: Install run: pnpm i diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 94df81b574fe..ae652230840a 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -5786,7 +5786,7 @@ packages: engines: {node: ^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0} dependencies: '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 chalk: 4.1.2 jest-message-util: 27.5.1 jest-util: 27.5.1 @@ -5807,7 +5807,7 @@ packages: '@jest/test-result': 27.5.1 '@jest/transform': 27.5.1 '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 ansi-escapes: 4.3.2 chalk: 4.1.2 emittery: 0.8.1 @@ -5844,7 +5844,7 @@ packages: dependencies: '@jest/fake-timers': 27.5.1 '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 jest-mock: 27.5.1 dev: true @@ -5861,7 +5861,7 @@ packages: dependencies: '@jest/types': 27.5.1 '@sinonjs/fake-timers': 8.1.0 - '@types/node': 20.11.20 + '@types/node': 20.11.24 jest-message-util: 27.5.1 jest-mock: 27.5.1 jest-util: 27.5.1 @@ -5890,7 +5890,7 @@ packages: '@jest/test-result': 27.5.1 '@jest/transform': 27.5.1 '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 chalk: 4.1.2 collect-v8-coverage: 1.0.2 exit: 0.1.2 @@ -6021,7 +6021,7 @@ packages: dependencies: '@types/istanbul-lib-coverage': 2.0.6 '@types/istanbul-reports': 3.0.4 - '@types/node': 20.11.20 + '@types/node': 20.11.24 '@types/yargs': 16.0.7 chalk: 4.1.2 dev: true @@ -9367,7 +9367,7 @@ packages: resolution: {integrity: sha512-N7UDG0/xiPQa2D/XrVJXjkWbpqHCd2sBaB32ggRF2l83RhPfamgKGF8gwwqyksS95qUS5ZYF9aF+lLPRlwI2UA==} dependencies: '@types/connect': 3.4.37 - '@types/node': 20.11.20 + '@types/node': 20.11.24 dev: true /@types/braces@3.0.1: @@ -9388,7 +9388,7 @@ packages: /@types/connect@3.4.37: resolution: {integrity: sha512-zBUSRqkfZ59OcwXon4HVxhx5oWCJmc0OtBTK05M+p0dYjgN6iTwIL2T/WbsQZrEsdnwaF9cWQ+azOnpPvIqY3Q==} dependencies: - '@types/node': 20.11.20 + '@types/node': 20.11.24 dev: true /@types/cookie@0.4.1: @@ -9455,7 +9455,7 @@ packages: /@types/express-serve-static-core@4.17.39: resolution: {integrity: sha512-BiEUfAiGCOllomsRAZOiMFP7LAnrifHpt56pc4Z7l9K6ACyN06Ns1JLMBxwkfLOjJRlSf06NwWsT7yzfpaVpyQ==} dependencies: - '@types/node': 20.11.20 + '@types/node': 20.11.24 '@types/qs': 6.9.9 '@types/range-parser': 1.2.6 '@types/send': 0.17.3 @@ -9516,7 +9516,7 @@ packages: /@types/graceful-fs@4.1.8: resolution: {integrity: sha512-NhRH7YzWq8WiNKVavKPBmtLYZHxNY19Hh+az28O/phfp68CF45pMFud+ZzJ8ewnxnC5smIdF3dqFeiSUQ5I+pw==} dependencies: - '@types/node': 20.11.20 + '@types/node': 20.11.24 dev: true /@types/hast@2.3.4: @@ -9676,7 +9676,7 @@ packages: /@types/node-fetch@2.6.7: resolution: {integrity: sha512-lX17GZVpJ/fuCjguZ5b3TjEbSENxmEk1B2z02yoXSK9WMEWRivhdSY73wWMn6bpcCDAOh6qAdktpKHIlkDk2lg==} dependencies: - '@types/node': 20.11.20 + '@types/node': 20.11.24 form-data: 4.0.0 dev: true @@ -9703,8 +9703,8 @@ packages: undici-types: 5.26.5 dev: true - /@types/node@20.11.20: - resolution: {integrity: sha512-7/rR21OS+fq8IyHTgtLkDK949uzsa6n8BkziAKtPVpugIkO6D+/ooXMvzXxDnZrmtXVfjb1bKQafYpb8s89LOg==} + /@types/node@20.11.24: + resolution: {integrity: sha512-Kza43ewS3xoLgCEpQrsT+xRo/EJej1y0kVYGiLFE1NEODXGzTfwiC6tXTLMQskn1X4/Rjlh0MQUvx9W+L9long==} dependencies: undici-types: 5.26.5 dev: true @@ -9868,7 +9868,7 @@ packages: /@types/resolve@1.17.1: resolution: {integrity: sha512-yy7HuzQhj0dhGpD8RLXSZWEkLsV9ibvxvi6EiJ3bkqLAO1RGo0WbkWQiwpRlSFymTJRz0d3k5LM3kkx8ArDbLw==} dependencies: - '@types/node': 20.11.20 + '@types/node': 20.11.24 dev: true /@types/resolve@1.20.2: @@ -9886,7 +9886,7 @@ packages: resolution: {integrity: sha512-/7fKxvKUoETxjFUsuFlPB9YndePpxxRAOfGC/yJdc9kTjTeP5kRCTzfnE8kPUKCeyiyIZu0YQ76s50hCedI1ug==} dependencies: '@types/mime': 1.3.4 - '@types/node': 20.11.20 + '@types/node': 20.11.24 dev: true /@types/serve-static@1.15.4: @@ -9894,7 +9894,7 @@ packages: dependencies: '@types/http-errors': 2.0.3 '@types/mime': 3.0.3 - '@types/node': 20.11.20 + '@types/node': 20.11.24 dev: true /@types/set-cookie-parser@2.4.2: @@ -18913,7 +18913,7 @@ packages: '@jest/environment': 27.5.1 '@jest/test-result': 27.5.1 '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 chalk: 4.1.2 co: 4.6.0 dedent: 0.7.0 @@ -19048,7 +19048,7 @@ packages: '@jest/environment': 27.5.1 '@jest/fake-timers': 27.5.1 '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 jest-mock: 27.5.1 jest-util: 27.5.1 jsdom: 16.7.0 @@ -19066,7 +19066,7 @@ packages: '@jest/environment': 27.5.1 '@jest/fake-timers': 27.5.1 '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 jest-mock: 27.5.1 jest-util: 27.5.1 dev: true @@ -19110,7 +19110,7 @@ packages: dependencies: '@jest/types': 27.5.1 '@types/graceful-fs': 4.1.8 - '@types/node': 20.11.20 + '@types/node': 20.11.24 anymatch: 3.1.3 fb-watchman: 2.0.2 graceful-fs: 4.2.11 @@ -19150,7 +19150,7 @@ packages: '@jest/source-map': 27.5.1 '@jest/test-result': 27.5.1 '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 chalk: 4.1.2 co: 4.6.0 expect: 27.5.1 @@ -19230,7 +19230,7 @@ packages: engines: {node: ^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0} dependencies: '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 dev: true /jest-pnp-resolver@1.2.3(jest-resolve@27.5.1): @@ -19291,7 +19291,7 @@ packages: '@jest/test-result': 27.5.1 '@jest/transform': 27.5.1 '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 chalk: 4.1.2 emittery: 0.8.1 graceful-fs: 4.2.11 @@ -19356,7 +19356,7 @@ packages: resolution: {integrity: sha512-jZCyo6iIxO1aqUxpuBlwTDMkzOAJS4a3eYz3YzgxxVQFwLeSA7Jfq5cbqCY+JLvTDrWirgusI/0KwxKMgrdf7w==} engines: {node: ^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0} dependencies: - '@types/node': 20.11.20 + '@types/node': 20.11.24 graceful-fs: 4.2.11 dev: true @@ -19407,7 +19407,7 @@ packages: engines: {node: ^10.13.0 || ^12.13.0 || ^14.15.0 || >=15.0.0} dependencies: '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 chalk: 4.1.2 ci-info: 3.9.0 graceful-fs: 4.2.11 @@ -19444,7 +19444,7 @@ packages: dependencies: '@jest/test-result': 27.5.1 '@jest/types': 27.5.1 - '@types/node': 20.11.20 + '@types/node': 20.11.24 ansi-escapes: 4.3.2 chalk: 4.1.2 jest-util: 27.5.1 From 49ff96a54402e0764cf7062cfa2f58c0d3e6c07c Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 1 Mar 2024 10:26:54 +0900 Subject: [PATCH 4/8] ci: pnpm exec --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 2b0b33350a56..b517090a7dea 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -68,9 +68,9 @@ jobs: steps: - uses: actions/checkout@v4 - # - uses: ./.github/actions/setup-and-cache - # with: - # node-version: ${{ matrix.node_version }} + - uses: ./.github/actions/setup-and-cache + with: + node-version: ${{ matrix.node_version }} # - uses: browser-actions/setup-chrome@v1 @@ -78,7 +78,7 @@ jobs: run: pnpm i - name: Install Playwright Dependencies - run: pnpx playwright install --with-deps + run: pnpm exec playwright install --with-deps - name: Build run: pnpm run build From af3abe8757f38d3e96f573a8520bd5ded976c9a3 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 1 Mar 2024 10:29:59 +0900 Subject: [PATCH 5/8] chore: move @playwright/test dep to root --- package.json | 1 + pnpm-lock.yaml | 6 +++--- test/ui/package.json | 1 - 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index a95b1b692d84..aadfb05c49d2 100644 --- a/package.json +++ b/package.json @@ -40,6 +40,7 @@ "devDependencies": { "@antfu/eslint-config": "^2.6.4", "@antfu/ni": "^0.21.12", + "@playwright/test": "^1.41.0", "@rollup/plugin-commonjs": "^25.0.7", "@rollup/plugin-json": "^6.0.1", "@rollup/plugin-node-resolve": "^15.2.3", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index ae652230840a..2b79c7577f3a 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -30,6 +30,9 @@ importers: '@antfu/ni': specifier: ^0.21.12 version: 0.21.12 + '@playwright/test': + specifier: ^1.41.0 + version: 1.41.0 '@rollup/plugin-commonjs': specifier: ^25.0.7 version: 25.0.7(rollup@4.9.6) @@ -2018,9 +2021,6 @@ importers: test/ui: devDependencies: - '@playwright/test': - specifier: ^1.41.0 - version: 1.41.0 '@testing-library/dom': specifier: ^9.3.3 version: 9.3.3 diff --git a/test/ui/package.json b/test/ui/package.json index 9b59a60c3dde..f78c450b4f65 100644 --- a/test/ui/package.json +++ b/test/ui/package.json @@ -7,7 +7,6 @@ "test-fixtures": "vitest" }, "devDependencies": { - "@playwright/test": "^1.41.0", "@testing-library/dom": "^9.3.3", "happy-dom": "latest", "vitest": "workspace:*" From 4d397e149b70b765ebf95f29f2b74d71541dae50 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 1 Mar 2024 10:34:34 +0900 Subject: [PATCH 6/8] chore: revert --- .github/workflows/ci.yml | 294 +++++++++++++++++---------------------- 1 file changed, 128 insertions(+), 166 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b517090a7dea..45d49aa08936 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,51 +19,50 @@ env: CYPRESS_CACHE_FOLDER: ${{ github.workspace }}/.cache/Cypress jobs: - # lint: - # runs-on: ubuntu-latest - # steps: - # - uses: actions/checkout@v4 + lint: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 - # - uses: ./.github/actions/setup-and-cache + - uses: ./.github/actions/setup-and-cache - # - name: Install - # run: pnpm i + - name: Install + run: pnpm i - # - name: Lint - # run: pnpm run lint + - name: Lint + run: pnpm run lint - # typecheck: - # runs-on: ubuntu-latest - # steps: - # - uses: actions/checkout@v4 + typecheck: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v4 - # - uses: ./.github/actions/setup-and-cache + - uses: ./.github/actions/setup-and-cache - # - name: Install - # run: pnpm i + - name: Install + run: pnpm i - # - name: Build - # run: pnpm run build + - name: Build + run: pnpm run build - # - name: Typecheck - # run: pnpm run typecheck + - name: Typecheck + run: pnpm run typecheck - debug: - runs-on: ubuntu-latest - # runs-on: ${{ matrix.os }} + test: + runs-on: ${{ matrix.os }} - # timeout-minutes: 30 + timeout-minutes: 30 - # strategy: - # matrix: - # os: [ubuntu-latest] - # node_version: [18, 20] - # include: - # - os: macos-14 - # node_version: 20 - # - os: windows-latest - # node_version: 20 - # fail-fast: false + strategy: + matrix: + os: [ubuntu-latest] + node_version: [18, 20] + include: + - os: macos-14 + node_version: 20 + - os: windows-latest + node_version: 20 + fail-fast: false steps: - uses: actions/checkout@v4 @@ -72,182 +71,145 @@ jobs: with: node-version: ${{ matrix.node_version }} - # - uses: browser-actions/setup-chrome@v1 + - uses: browser-actions/setup-chrome@v1 - name: Install run: pnpm i - name: Install Playwright Dependencies - run: pnpm exec playwright install --with-deps + run: pnpx playwright install --with-deps - name: Build run: pnpm run build - name: Test - run: pnpm -C examples/playwright test - - # test: - # runs-on: ${{ matrix.os }} + run: pnpm run test:ci - # timeout-minutes: 30 + - name: Test No Threads + run: pnpm run test:ci:no-threads - # strategy: - # matrix: - # os: [ubuntu-latest] - # node_version: [18, 20] - # include: - # - os: macos-14 - # node_version: 20 - # - os: windows-latest - # node_version: 20 - # fail-fast: false + - name: Test Vm Threads + run: pnpm run test:ci:vm-threads - # steps: - # - uses: actions/checkout@v4 - - # - uses: ./.github/actions/setup-and-cache - # with: - # node-version: ${{ matrix.node_version }} - - # - uses: browser-actions/setup-chrome@v1 - - # - name: Install - # run: pnpm i - - # - name: Install Playwright Dependencies - # run: pnpx playwright install --with-deps - - # - name: Build - # run: pnpm run build - - # - name: Test - # run: pnpm run test:ci - - # - name: Test No Threads - # run: pnpm run test:ci:no-threads - - # - name: Test Vm Threads - # run: pnpm run test:ci:vm-threads - - # test-ui: - # runs-on: ubuntu-latest + test-ui: + runs-on: ubuntu-latest - # timeout-minutes: 10 + timeout-minutes: 10 - # steps: - # - uses: actions/checkout@v4 + steps: + - uses: actions/checkout@v4 - # - uses: ./.github/actions/setup-and-cache - # with: - # node-version: 20 + - uses: ./.github/actions/setup-and-cache + with: + node-version: 20 - # - name: Install - # run: pnpm i + - name: Install + run: pnpm i - # - name: Test UI - # run: pnpm run ui:test + - name: Test UI + run: pnpm run ui:test - # test-ui-e2e: - # strategy: - # matrix: - # os: [ubuntu-latest, macos-14, windows-latest] - # fail-fast: false + test-ui-e2e: + strategy: + matrix: + os: [ubuntu-latest, macos-14, windows-latest] + fail-fast: false - # runs-on: ${{ matrix.os }} + runs-on: ${{ matrix.os }} - # timeout-minutes: 30 + timeout-minutes: 30 - # steps: - # - uses: actions/checkout@v4 + steps: + - uses: actions/checkout@v4 - # - uses: ./.github/actions/setup-and-cache - # with: - # node-version: 20 + - uses: ./.github/actions/setup-and-cache + with: + node-version: 20 - # - name: Install - # run: pnpm i + - name: Install + run: pnpm i - # - name: Install Playwright Dependencies - # run: pnpx playwright install chromium + - name: Install Playwright Dependencies + run: pnpx playwright install chromium - # - name: Build - # run: pnpm run build + - name: Build + run: pnpm run build - # - name: Test - # run: pnpm -C test/ui test-e2e + - name: Test + run: pnpm -C test/ui test-e2e - # test-browser: - # runs-on: ubuntu-latest - # strategy: - # matrix: - # browser: [[chrome, chromium], [firefox, firefox], [edge, webkit]] - # fail-fast: false + test-browser: + runs-on: ubuntu-latest + strategy: + matrix: + browser: [[chrome, chromium], [firefox, firefox], [edge, webkit]] + fail-fast: false - # timeout-minutes: 30 + timeout-minutes: 30 - # env: - # BROWSER: ${{ matrix.browser[0] }} - # steps: - # - uses: actions/checkout@v4 + env: + BROWSER: ${{ matrix.browser[0] }} + steps: + - uses: actions/checkout@v4 - # - uses: ./.github/actions/setup-and-cache - # with: - # node-version: 20 + - uses: ./.github/actions/setup-and-cache + with: + node-version: 20 - # - uses: browser-actions/setup-chrome@v1 - # - uses: browser-actions/setup-firefox@v1 + - uses: browser-actions/setup-chrome@v1 + - uses: browser-actions/setup-firefox@v1 - # - name: Install - # run: pnpm i + - name: Install + run: pnpm i - # - name: Install Playwright Dependencies - # run: pnpx playwright install --with-deps + - name: Install Playwright Dependencies + run: pnpx playwright install --with-deps - # - name: Build - # run: pnpm run build + - name: Build + run: pnpm run build - # - name: Test Browser (webdriverio) - # run: pnpm run test:browser:webdriverio + - name: Test Browser (webdriverio) + run: pnpm run test:browser:webdriverio - # - name: Test Browser (playwright) - # run: pnpm run test:browser:playwright - # env: - # BROWSER: ${{ matrix.browser[1] }} + - name: Test Browser (playwright) + run: pnpm run test:browser:playwright + env: + BROWSER: ${{ matrix.browser[1] }} - # test-browser-windows: - # runs-on: windows-latest - # strategy: - # matrix: - # browser: [[chrome, chromium], [edge, webkit]] - # fail-fast: false + test-browser-windows: + runs-on: windows-latest + strategy: + matrix: + browser: [[chrome, chromium], [edge, webkit]] + fail-fast: false - # timeout-minutes: 30 + timeout-minutes: 30 - # env: - # BROWSER: ${{ matrix.browser[0] }} - # steps: - # - uses: actions/checkout@v4 + env: + BROWSER: ${{ matrix.browser[0] }} + steps: + - uses: actions/checkout@v4 - # - uses: ./.github/actions/setup-and-cache - # with: - # node-version: 20 + - uses: ./.github/actions/setup-and-cache + with: + node-version: 20 - # - uses: browser-actions/setup-chrome@v1 - # - uses: browser-actions/setup-edge@v1 + - uses: browser-actions/setup-chrome@v1 + - uses: browser-actions/setup-edge@v1 - # - name: Install - # run: pnpm i + - name: Install + run: pnpm i - # - name: Install Playwright Dependencies - # run: pnpx playwright install --with-deps + - name: Install Playwright Dependencies + run: pnpx playwright install --with-deps - # - name: Build - # run: pnpm run build + - name: Build + run: pnpm run build - # - name: Test Browser (webdriverio) - # run: pnpm run test:browser:webdriverio + - name: Test Browser (webdriverio) + run: pnpm run test:browser:webdriverio - # - name: Test Browser (playwright) - # run: pnpm run test:browser:playwright - # env: - # BROWSER: ${{ matrix.browser[1] }} + - name: Test Browser (playwright) + run: pnpm run test:browser:playwright + env: + BROWSER: ${{ matrix.browser[1] }} From 87c88282adf6b8759fb7d3ecb9322decb7805773 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 1 Mar 2024 10:34:41 +0900 Subject: [PATCH 7/8] ci: replace "pnpx" with "pnpm exec" --- .github/workflows/ci.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 45d49aa08936..d020f7cdc12d 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -77,7 +77,7 @@ jobs: run: pnpm i - name: Install Playwright Dependencies - run: pnpx playwright install --with-deps + run: pnpm exec playwright install --with-deps - name: Build run: pnpm run build @@ -130,7 +130,7 @@ jobs: run: pnpm i - name: Install Playwright Dependencies - run: pnpx playwright install chromium + run: pnpm exec playwright install chromium - name: Build run: pnpm run build @@ -163,7 +163,7 @@ jobs: run: pnpm i - name: Install Playwright Dependencies - run: pnpx playwright install --with-deps + run: pnpm exec playwright install --with-deps - name: Build run: pnpm run build @@ -201,7 +201,7 @@ jobs: run: pnpm i - name: Install Playwright Dependencies - run: pnpx playwright install --with-deps + run: pnpm exec playwright install --with-deps - name: Build run: pnpm run build From a14b648d354bd2e2ea2114c5d744a42ee1ced90c Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Fri, 1 Mar 2024 10:57:06 +0900 Subject: [PATCH 8/8] chore: revert --- wip.txt | 1 - 1 file changed, 1 deletion(-) delete mode 100644 wip.txt diff --git a/wip.txt b/wip.txt deleted file mode 100644 index e7123041ee04..000000000000 --- a/wip.txt +++ /dev/null @@ -1 +0,0 @@ -wip