From 131690f71a9ba21a8ef5ca32d4cf53a7c9e47cdf Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Tue, 5 Mar 2024 09:40:51 +0900 Subject: [PATCH 1/2] fix(vitest): loosen onConsoleLog return type --- packages/vitest/src/types/config.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vitest/src/types/config.ts b/packages/vitest/src/types/config.ts index b8db4b5e5d49..2c1e5951d3c5 100644 --- a/packages/vitest/src/types/config.ts +++ b/packages/vitest/src/types/config.ts @@ -580,7 +580,7 @@ export interface InlineConfig { * * Return `false` to ignore the log. */ - onConsoleLog?: (log: string, type: 'stdout' | 'stderr') => false | void + onConsoleLog?: (log: string, type: 'stdout' | 'stderr') => boolean | void /** * Enable stack trace filtering. If absent, all stack trace frames From 95674ac6c41ad260333017942ba6c09dfa796b75 Mon Sep 17 00:00:00 2001 From: Hiroshi Ogawa Date: Tue, 5 Mar 2024 09:54:23 +0900 Subject: [PATCH 2/2] test: update usage --- test/web-worker/vitest.config.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/web-worker/vitest.config.ts b/test/web-worker/vitest.config.ts index c6de0b5c72d0..e2505eb392e5 100644 --- a/test/web-worker/vitest.config.ts +++ b/test/web-worker/vitest.config.ts @@ -13,8 +13,7 @@ export default defineConfig({ }, }, onConsoleLog(log) { - if (log.includes('Failed to load')) - return false + return !log.includes('Failed to load') }, }, })