From 1ca66fe6d15b3a827a4deb57f3538ccb56640d4f Mon Sep 17 00:00:00 2001 From: Michel EDIGHOFFER Date: Mon, 24 Jan 2022 20:23:35 +0100 Subject: [PATCH 1/2] fix: add async to onFinish report event --- packages/vitest/src/api/setup.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/vitest/src/api/setup.ts b/packages/vitest/src/api/setup.ts index 2742ae27d4d7..7351d4e3b9c3 100644 --- a/packages/vitest/src/api/setup.ts +++ b/packages/vitest/src/api/setup.ts @@ -146,7 +146,7 @@ class WebSocketReporter implements Reporter { }) } - onFinished(files?: File[] | undefined) { + async onFinished(files?: File[] | undefined) { this.clients.forEach((client) => { client.onFinished?.(files) }) From 34071b2ed5b8778270cfbf1e2a09512ed7ed3230 Mon Sep 17 00:00:00 2001 From: Michel EDIGHOFFER Date: Tue, 25 Jan 2022 00:41:50 +0100 Subject: [PATCH 2/2] fix: remove unnecessary Awaitable --- packages/vitest/src/types/reporter.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/vitest/src/types/reporter.ts b/packages/vitest/src/types/reporter.ts index 242f9af3d8b5..fe3d57845c47 100644 --- a/packages/vitest/src/types/reporter.ts +++ b/packages/vitest/src/types/reporter.ts @@ -4,7 +4,7 @@ import type { File, TaskResultPack } from './tasks' export interface Reporter { onInit?(ctx: Vitest): void - onCollected?: (files?: File[]) => Awaitable + onCollected?: (files?: File[]) => void onFinished?: (files?: File[]) => Awaitable onTaskUpdate?: (packs: TaskResultPack[]) => Awaitable @@ -13,5 +13,5 @@ export interface Reporter { onServerRestart?: () => Awaitable - onUserConsoleLog?: (log: UserConsoleLog) => Awaitable + onUserConsoleLog?: (log: UserConsoleLog) => void }