From a91b2eb0e2e6066b25df75fb9e79def3c0f138bc Mon Sep 17 00:00:00 2001 From: Debadree Chatterjee Date: Wed, 28 Dec 2022 17:29:41 +0530 Subject: [PATCH] debugger: refactor console in lib/internal/debugger/inspect.js Refs: https://github.com/nodejs/node/pull/38406/ PR-URL: https://github.com/nodejs/node/pull/45847 Reviewed-By: Antoine du Hamel Reviewed-By: Joyee Cheung Reviewed-By: Kohei Ueno --- lib/internal/debugger/inspect.js | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/lib/internal/debugger/inspect.js b/lib/internal/debugger/inspect.js index edaa1a622f3ca0..691314605cfd7d 100644 --- a/lib/internal/debugger/inspect.js +++ b/lib/internal/debugger/inspect.js @@ -32,9 +32,6 @@ const { AbortController, } = require('internal/abort_controller'); -// TODO(aduh95): remove console calls -const console = require('internal/console/global'); - const { 0: InspectClient, 1: createRepl } = [ require('internal/debugger/inspect_client'), @@ -318,7 +315,7 @@ function parseArgv(args) { process._debugProcess(pid); } catch (e) { if (e.code === 'ESRCH') { - console.error(`Target process: ${pid} doesn't exist.`); + process.stderr.write(`Target process: ${pid} doesn't exist.\n`); process.exit(kGenericUserError); } throw e; @@ -338,10 +335,10 @@ function startInspect(argv = ArrayPrototypeSlice(process.argv, 2), if (argv.length < 1) { const invokedAs = `${process.argv0} ${process.argv[1]}`; - console.error(`Usage: ${invokedAs} script.js`); - console.error(` ${invokedAs} :`); - console.error(` ${invokedAs} --port=`); - console.error(` ${invokedAs} -p `); + process.stderr.write(`Usage: ${invokedAs} script.js\n` + + ` ${invokedAs} :\n` + + ` ${invokedAs} --port=\n` + + ` ${invokedAs} -p \n`); // TODO(joyeecheung): should be kInvalidCommandLineArgument. process.exit(kGenericUserError); } @@ -353,12 +350,12 @@ function startInspect(argv = ArrayPrototypeSlice(process.argv, 2), function handleUnexpectedError(e) { if (e.code !== 'ERR_DEBUGGER_STARTUP_ERROR') { - console.error('There was an internal error in Node.js. ' + - 'Please report this bug.'); - console.error(e.message); - console.error(e.stack); + process.stderr.write('There was an internal error in Node.js. ' + + 'Please report this bug.\n' + + `${e.message}\n${e.stack}\n`); } else { - console.error(e.message); + process.stderr.write(e.message); + process.stderr.write('\n'); } if (inspector.child) inspector.child.kill(); process.exit(kGenericUserError);