Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting vite.root breaks build #33

Open
Hagith opened this issue Dec 9, 2023 · 1 comment · May be fixed by #34
Open

Setting vite.root breaks build #33

Hagith opened this issue Dec 9, 2023 · 1 comment · May be fixed by #34

Comments

@Hagith
Copy link

Hagith commented Dec 9, 2023 •
edited

When setting vite.root to ./src build is broken.
Here is the reproduction repo: https://github.com/Hagith/vituum-path-resolution/

In my opinion it is mostly caused by defaultInput paths prefixed with ./src/pages. All those paths should include pages.root and pages.dir, which are expected to be relative to vite.root.

Maybe I'm missing something in my config. If you think it's not a bug, please let me know.

I'm working on a potential fix.
Hagith added a commit to modernweb-pl/vituum that referenced this issue Dec 10, 2023
@Hagith
fix: path resolution when vite.root is set
3a8860c 
Resolves vituum#33
@Hagith Hagith linked a pull request Dec 10, 2023 that will close this issue
Open
@Hagith
Copy link
Author

Hagith commented Dec 10, 2023

The fix is ready. No tests yet, but working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: path resolution when vite.root is set modernweb-pl/vituum
1 participant
@Hagith