Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cyrillic does not show up in Hello VizHub #187

Closed
tasqon opened this issue Jan 29, 2019 · 3 comments
Closed

Cyrillic does not show up in Hello VizHub #187

tasqon opened this issue Jan 29, 2019 · 3 comments

Comments

@tasqon
Copy link

tasqon commented Jan 29, 2019

I fail to get the cyrillic font to work in the Hello VizHub example.

Instead of message "Hello VizHub!" I want "Привет VizHub!". The default Ubuntu font family in styles.css should work with that Russian Hello (Привет) according to the Google Font Directory. Any hints?

Please 👍 this issue to help prioritize this task in our backlog.

@curran
Copy link
Contributor

curran commented Jan 30, 2019

@tasqon Thanks for filing this issue!

I'm able to reproduce it here https://vizhub.com/tasqon/d7dd260979aa4009a397193bfcbb5816 , and I notice the error looks like this:

InvalidCharacterError: Failed to execute 'btoa' on 'Window': The string to be encoded contains characters outside of the Latin1 range.
(bundle.js not updated)

Will investigate further.

Possibly related https://developer.mozilla.org/en-US/docs/Web/API/WindowOrWorkerGlobalScope/btoa#Unicode_strings

Looks like the error originates here in magic-string https://github.com/Rich-Harris/magic-string/blob/3466b0230dddc95eb378ed3e0d199e36fbd1f572/src/SourceMap.js#L4

@curran
Copy link
Contributor

curran commented Jan 30, 2019

Filed related issue in magic-string Rich-Harris/magic-string#154

@curran
Copy link
Contributor

curran commented Jan 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants