{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":704160545,"defaultBranch":"main","name":"go-cobra","ownerLogin":"vkhoroz","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-10-12T16:58:32.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/2146687?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1698759027.0","currentOid":""},"activityList":{"items":[{"before":"f1f4087fc2ab8f405bcb728990a18162e045fd52","after":null,"ref":"refs/heads/run-parent-persistent-runs","pushedAt":"2023-10-31T13:30:27.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"vkhoroz","name":null,"path":"/vkhoroz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2146687?s=80&v=4"}},{"before":"589693b84870c0228d123904ff62fd4bca24d301","after":"f1f4087fc2ab8f405bcb728990a18162e045fd52","ref":"refs/heads/run-parent-persistent-runs","pushedAt":"2023-10-18T14:18:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vkhoroz","name":null,"path":"/vkhoroz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2146687?s=80&v=4"},"commit":{"message":"Feature: allow running persistent run hooks of all parents\n\nCurrently, only one of the persistent pre-runs and post-runs is executed.\nIt is always the first one found in the parents chain, starting at this command.\nExpected behavior is to execute all parents' persistent pre-runs and post-runs.\n\nDependent projects implemented various workarounds for this:\n- manually building persistent hook chains (in every hook).\n- applying some kind of monkey-patching on top of Cobra.\n\nThis change eliminates the necessity for such workarounds\nby allowing to set a global variable EnableTraverseRunHooks.\n\nTickets:\n- https://github.com/spf13/cobra/issues/216\n- https://github.com/spf13/cobra/issues/252\n\nSigned-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>","shortMessageHtmlLink":"Feature: allow running persistent run hooks of all parents"}},{"before":"88458dcfbc3a2f3addc7e4ae6c3a9007e9081caf","after":"589693b84870c0228d123904ff62fd4bca24d301","ref":"refs/heads/run-parent-persistent-runs","pushedAt":"2023-10-12T18:25:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vkhoroz","name":null,"path":"/vkhoroz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2146687?s=80&v=4"},"commit":{"message":"Feature: allow running persistent run hooks of all parents\n\nCurrently, only one of the persistent pre-runs and post-runs is executed.\nIt is always the first one found in the parents chain, starting at this command.\nExpected behavior is to execute all parents' persistent pre-runs and post-runs.\n\nDependent projects implemented various workarounds for this:\n- manually building persistent hook chains (in every hook).\n- applying some kind of monkey-patching on top of Cobra.\n\nThis change eliminates the necessity for such workarounds\nby allowing to set a global variable EnableTraverseRunHooks.\n\nTickets:\n- https://github.com/spf13/cobra/issues/216\n- https://github.com/spf13/cobra/issues/252\n\nSigned-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>","shortMessageHtmlLink":"Feature: allow running persistent run hooks of all parents"}},{"before":"90043519295c4e6a9d90601b5c178783f1e14229","after":"88458dcfbc3a2f3addc7e4ae6c3a9007e9081caf","ref":"refs/heads/run-parent-persistent-runs","pushedAt":"2023-10-12T18:24:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"vkhoroz","name":null,"path":"/vkhoroz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2146687?s=80&v=4"},"commit":{"message":"Feature: allow to run all persistent pre-runs and post-runs of all parents\n\nCurrently, only one of the persistent pre-runs and post-runs is executed.\nIt is always the first one found in the parents chain, starting at this command.\nExpected behavior is to execute all parents' persistent pre-runs and post-runs.\n\nDependent projects implemented various workarounds for this:\n- manually building persistent hook chains (in every hook).\n- applying some kind of monkey-patching on top of Cobra.\n\nThis change eliminates the necessity for such workarounds\nby allowing to set a global variable EnableTraverseRunHooks.\n\nTickets:\n- https://github.com/spf13/cobra/issues/216\n- https://github.com/spf13/cobra/issues/252\n\nSigned-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>","shortMessageHtmlLink":"Feature: allow to run all persistent pre-runs and post-runs of all pa…"}},{"before":null,"after":"90043519295c4e6a9d90601b5c178783f1e14229","ref":"refs/heads/run-parent-persistent-runs","pushedAt":"2023-10-12T17:46:07.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"vkhoroz","name":null,"path":"/vkhoroz","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/2146687?s=80&v=4"},"commit":{"message":"Bugfix: run all persistent pre-runs and post-runs of all parents\n\nCurrently, only one of the persistent pre-runs and post-runs is executed.\nIt is always the first one found in the parents chain, starting at this command.\nExpected behavior is to execute all parents' persistent pre-runs and post-runs.\n\nDependent projects implemented various workarounds for this:\n- manually building persistent hook chains (in every hook).\n- applying some kind of monkey-patching on top of Cobra.\n\nThis change eliminates the necessity for such workarounds.\n\nNote: when merged, commands which built hook chains manually\nmay call parents' persistent pre-runs and post-runs a more than once.\nThis is not a big deal when persistent hooks are used properly.\nOtherwise, such projects need to be modified.\n\nBased on the ticket history there is a limited number of projects which need to update:\n- https://github.com/spf13/cobra/issues/216\n- https://github.com/spf13/cobra/issues/252\n\nSigned-off-by: Volodymyr Khoroz <volodymyr.khoroz@foundries.io>","shortMessageHtmlLink":"Bugfix: run all persistent pre-runs and post-runs of all parents"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADpAp52wA","startCursor":null,"endCursor":null}},"title":"Activity · vkhoroz/go-cobra"}