Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incopatibility of 5.0 version with Kubernetess Java Client #110

Closed
vladimir-bukhtoyarov opened this issue Jan 11, 2020 · 2 comments
Closed

Comments

@vladimir-bukhtoyarov
Copy link
Collaborator

In the scope of upcoming 5.0 version async functionality was removed for non-distributed buckets as useless(because local buckets is extremely fast and there is no reason to await results of operations in async way). But in the result of the investigation of Bucket4j's dependencies, I found that Kubernetes Java Client uses async buckets in the non-distributed environment. The reason to do that is simple, they just want to consume tokens unconditionally(independently of the fact if limitation violated or not) and just track the amount of violation.

To fix compatibility with Bucket4j 5.0 it needs to do the following:

@vladimir-bukhtoyarov vladimir-bukhtoyarov moved this from In-progress to Planned in 7.0 - Conquer the world Jan 11, 2020
@vladimir-bukhtoyarov
Copy link
Collaborator Author

Plans have been changed. This feature will be released under separated version 4.8

@vladimir-bukhtoyarov
Copy link
Collaborator Author

PR was created kubernetes-client/java#858

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant