Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the JavaMoney (JSR 354) CurrencyUnit #473

Closed
piotrooo opened this issue Aug 12, 2022 · 3 comments
Closed

Add support for the JavaMoney (JSR 354) CurrencyUnit #473

piotrooo opened this issue Aug 12, 2022 · 3 comments
Assignees
Milestone

Comments

@piotrooo
Copy link
Contributor

Hello @vladmihalcea!
I hope you're fine.

I come with another idea about extending types. We can add currency ISO-4217 codes.
It looks like:

@Column(name = "currency")
private CurrencyUnit currency;

What do you think? If you are interested in, I implemented almost everything what is needed.

Another question, I see you add Money handling for Hibernate versions >5, that is intentionally? Because I make implementation for all of Hibernate versions. If is, maybe pom's should be cleaned and removed Moneta dependency.

If it's ok, I can implement for all Hibernate versions >5.

@vladmihalcea
Copy link
Owner

Yes, please. The reason these Types are used on 5.2 or later is that it needs Java 8.

@piotrooo
Copy link
Contributor Author

Sure. You can assign me to this issue.

@vladmihalcea vladmihalcea changed the title Add CurrencyUnit type Add a CurrencyUnitType to map the CurrencyUnit from JavaMoney (JSR 354) Aug 15, 2022
@vladmihalcea vladmihalcea changed the title Add a CurrencyUnitType to map the CurrencyUnit from JavaMoney (JSR 354) Add support for the JavaMoney (JSR 354) CurrencyUnit Aug 15, 2022
@vladmihalcea vladmihalcea added this to the 2.18.0 milestone Aug 15, 2022
@vladmihalcea
Copy link
Owner

Applied upstream, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants