Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArrayType causes org.hibernate.tool.schema.spi.SchemaManagementException: Schema-validation: wrong column type encountered in column found (Types#ARRAY), but expecting (Types#OTHER) with Hibernate 6.3 and 6.4 #697

Open
CorayThan opened this issue Jan 31, 2024 · 15 comments

Comments

@CorayThan
Copy link

CorayThan commented Jan 31, 2024

Describe the bug
When I upgrade from

hypersistence-utils-hibernate-62:3.7.1
to
hypersistence-utils-hibernate-63:3.7.1

The following code:

@Type(
     value = ListArrayType::class,
     parameters = [Parameter(
         value = "house",
         name = ListArrayType.SQL_ARRAY_TYPE,
     )]
 )
 @Column(columnDefinition = "house[]")
 val houses: List<House>,

Throws this error:

org.hibernate.tool.schema.spi.SchemaManagementException: Schema-validation: wrong column type encountered in column [houses] in table [dok_card]; found [_house (Types#ARRAY)], but expecting [house[] (Types#OTHER)]

My hibernate version is 6.4.1.Final.

To Reproduce

Follow the instructions here: https://vladmihalcea.com/postgresql-array-java-list/ with the latest version of hibernate and hypersistence-utils.

Expected behavior
No error is thrown when using a postgresql array of enums with a java list.

@vladmihalcea
Copy link
Owner

vladmihalcea commented Feb 1, 2024

The validation will no longer work since without using Types.OTHER, the ArrayTypes will not work at all. So, either you disable the schema validation or you switch to the Hibernate native ARRAY Type. There's no way at the moment to have both options.

If HHH-17588 will be fixed, then we can switch back to Types.ARRAY. In the meantime, you can try to migrate to the Hibernate native ARRAYs, as the native Types should be more stable since they are tested by the Hibernate ORM prior to any release.

@vladmihalcea vladmihalcea changed the title Hypersistence-Utils 63:3.7.1 causes bug with List mapped to PostgreSQL array ArrayType causes org.hibernate.tool.schema.spi.SchemaManagementException: Schema-validation: wrong column type encountered in column found (Types#ARRAY), but expecting (Types#OTHER) with Hibernate 6.3 and 6.4 Feb 3, 2024
@flozano
Copy link

flozano commented Feb 11, 2024

Just as a reference: I got affected by the same when upgrading from 3.7.0 to 3.7.2 with Hibernate 6.4 (which I think wasn't fully supported before :)

@vladmihalcea
Copy link
Owner

This issue is a side effect of #698. However, without it, you wouldn't be able to use the ArrayTypes from this library at all with Hibernate 6.4.

Check out my previous message for more details about it.

@flozano
Copy link

flozano commented Feb 11, 2024

Yes... I've tried moving to native array, but then when I trigger an update my enums try to get mapped to positional enum.
[ERROR: column "roles" is of type company_role[] but expression is of type smallint[]

@vladmihalcea
Copy link
Owner

You should open a Hibernate issue then. In the long run, it's better to have the native Type support everything this library has been supporting.

@GuiF007
Copy link

GuiF007 commented Feb 29, 2024

@vladmihalcea when you say "native Type support", it's implementation of UserType<String[]> for example ? (for a array of string)

Do you confirm your fix make it works better with Hibernate 6.4+ and only validation fail ?

@vladmihalcea
Copy link
Owner

vladmihalcea commented Feb 29, 2024

Native Type support is what Hibernate ORM offers by default without the need for custom UserType implementations.

The tests in the 63 module are running fine on Hibernate 6.4. That's the only thing I can confirm. If there are other issues, they will have to be replicated with additional integration tests.

If your project has integration tests for the entire data access logic, then you will know for sure whether a native Type or a custom one works or not. That's thr only confirmation that really matters.

@GuiF007
Copy link

GuiF007 commented Feb 29, 2024

Sure ! Thank you for fast answering ! Just wanted to know there is no known regression than the validation.
We will check to update to native support in any case.

@vladmihalcea
Copy link
Owner

The only known regressions are the ones for which there are Open issues on GitHub. There might be unknown regressions, of course.

@kth13
Copy link

kth13 commented Mar 4, 2024

Hi @vladmihalcea , I am facing the similar issue The code we have

@Type(ListArrayType::class) @Column(name = "disabilities", columnDefinition = "text[]") var disabilities: List<String>? = null,

What is your suggestion to change this using Hibernate native support

@vladmihalcea
Copy link
Owner

@kth13 Remove the @Type annotation and see if it works.

@kth13
Copy link

kth13 commented Mar 4, 2024

@vladmihalcea It worked, thanks a lot.

@vladmihalcea
Copy link
Owner

Great. The native Hibernate Type should be fine in many situations.

@Javasick
Copy link

How to implement array of SQL enum in 6.4?

    @Type(
        value = EnumArrayType.class,
        parameters = @Parameter(
            name = AbstractArrayType.SQL_ARRAY_TYPE,
            value = "status"
        )
    )
    @Column(name = "statuses", columnDefinition = "status[]")
    private Status[] statuses;

Native Type support cause the following error on saving:
column "statuses" is of type status[] but expression is of type smallint[]

@vladmihalcea
Copy link
Owner

@Javasick There is a PostgreSQLEnumArrayTypeTest that shows you how to use the EnumArrayType with Hibernate 6.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants