Track db versions count #310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gth on initial create
…adata weight reduction
…initial row sentinel
For some reason we create sentinels on merge
|
all those merge commits 😅 I've cleaned up the history and opened a new pr with your changes -- #313 |
|
I decided to use the clock tables directly in my queries in my program. This circumvents the performance regression explained in #313 Closing for now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #301
Creates a new table
crsql_db_versions_totalwhere the total number of changes per db version is tracked. This allows for our in-memory cache to be purged and therefore resources to be released.It creates 1 extra trigger per insert/update/delete per crr-tracked table and 1 "global" trigger that cleans up the table when the total count of db versions reaches zero to keep it lean.