Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sar output - add LANGUAGE support #265

Open
Pitterling opened this issue Jan 7, 2023 · 0 comments · Fixed by #275
Open

sar output - add LANGUAGE support #265

Pitterling opened this issue Jan 7, 2023 · 0 comments · Fixed by #275

Comments

@Pitterling
Copy link
Collaborator

currently only "english" sar outputs are supported - this is independend form the date/time formats.
language influences how Summary/Average lines are written to the sar files.

These lines must be filtered out, to avoid errors in later processing. A simple workaround would be to list all translations ...

private final HashSet<String> IgnoreLinesBeginningWith = new HashSet<>(Arrays.asList(
"Average:", "##", "Summary", "Summary:"));

  private final HashSet<String> IgnoreLinesBeginningWith = new HashSet<>(Arrays.asList(
      "##",
      "Average:", "Summary:", "Summary",  // en.po
      "Moyenne :", "Résumé:",         // fr.po
      "Durchschn.:", "Zusammenfassung:"   // de.po
  ));

but there are a lot of translations ..
https://translationproject.org/domain/sysstat.html
https://github.com/sysstat/sysstat/tree/master/nls

Another approach could be to include the translation *.po files and extract the corresponding msgid values:
msgid "Average:"
msgid "Summary:"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant