.gitattributes

@@ -6,7 +6,6 @@
 /.github export-ignore
 /.gitignore export-ignore
 /.github export-ignore
-/.travis.yml export-ignore
 /phpunit.xml.dist export-ignore
 /README.md export-ignore
 /UPGRADING.md export-ignore

.github/bin/composer.sh

@@ -0,0 +1,16 @@
+#!/bin/bash
+
+EXPECTED_CHECKSUM="$(wget -q -O - https://composer.github.io/installer.sig)"
+php -r "copy('https://getcomposer.org/installer', 'composer-setup.php');"
+ACTUAL_CHECKSUM="$(php -r "echo hash_file('sha384', 'composer-setup.php');")"
+if [ "$EXPECTED_CHECKSUM" != "$ACTUAL_CHECKSUM" ]; then
+  >&2 echo 'ERROR: Invalid installer checksum'
+  rm composer-setup.php
+  exit 1
+else
+  php composer-setup.php --install-dir="/usr/bin" --filename=composer
+  RESULT=$?
+  rm composer-setup.php
+  composer config platform.php 5.6.50
+  exit $RESULT
+fi

.github/bin/hhvm.sh

@@ -0,0 +1,5 @@
+#!/bin/bash
+
+echo "deb https://dl.hhvm.com/ubuntu $(lsb_release -sc)-lts-$1 main" >> /etc/apt/sources.list
+apt-get update
+apt-get --allow-downgrades --reinstall install hhvm/$(lsb_release -sc)-lts-$1

.github/workflows/tests.yml

@@ -5,13 +5,13 @@ on:
   pull_request:
 
 jobs:
-  tests:
+  php:
     name: PHP ${{ matrix.php }}
     runs-on: ubuntu-20.04
 
     strategy:
       matrix:
-        php: ['5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0']
+        php: ['5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0']
 
     steps:
       - name: Checkout Code
@@ -40,8 +40,38 @@ jobs:
         with:
           timeout_minutes: 5
           max_attempts: 5
-          command: composer update --no-interaction --no-progress --ignore-platform-reqs
+          command: composer update --no-interaction --no-progress --ignore-platform-req=php
         if: "matrix.php >= 8"
 
       - name: Execute PHPUnit
         run: vendor/bin/phpunit
+
+  hhvm:
+    name: HHVM ${{ matrix.hhvm }}
+    runs-on: ubuntu-16.04
+
+    strategy:
+      matrix:
+        hhvm: ["3.15", "3.18", "3.21", "3.24", "3.27", "3.30"]
+
+    steps:
+      - name: Checkout Code
+        uses: actions/checkout@v2
+
+      - name: Install HHVM
+        shell: bash
+        run: sudo .github/bin/hhvm.sh ${{ matrix.hhvm }}
+
+      - name: Install Composer
+        shell: bash
+        run: sudo .github/bin/composer.sh
+
+      - name: Install Dependencies
+        uses: nick-invision/retry@v1
+        with:
+          timeout_minutes: 5
+          max_attempts: 5
+          command: composer update --no-interaction --no-progress
+
+      - name: Execute PHPUnit
+        run: hhvm vendor/bin/phpunit

composer.json

@@ -23,7 +23,7 @@
     "require-dev": {
         "ext-filter": "*",
         "ext-pcre": "*",
-        "phpunit/phpunit": "^4.8.35 || ^5.7.27 || ^6.5.6 || ^7.0"
+        "phpunit/phpunit": "^4.8.36 || ^5.7.27 || ^6.5.14 || ^7.5.20"
     },
     "autoload": {
         "psr-4": {

src/Parser.php

@@ -106,7 +106,7 @@ private static function parseValue($value)
             return $value;
         }
 
-        return array_reduce(str_split($value), function ($data, $char) use ($value) {
+        $result = array_reduce(str_split($value), function ($data, $char) use ($value) {
             switch ($data[1]) {
                 case self::INITIAL_STATE:
                     if ($char === '"' || $char === '\'') {
@@ -155,7 +155,15 @@ private static function parseValue($value)
                 case self::COMMENT_STATE:
                     return [$data[0], self::COMMENT_STATE];
             }
-        }, ['', self::INITIAL_STATE])[0];
+        }, ['', self::INITIAL_STATE]);
+
+        if ($result[1] === self::QUOTED_STATE || $result[1] === self::ESCAPE_STATE) {
+            throw new InvalidFileException(
+                self::getErrorMessage('a missing closing quote', $value)
+            );
+        }
+
+        return $result[0];
     }
 
     /**

tests/Dotenv/LinesTest.php

@@ -51,4 +51,17 @@ public function testProcessClosingSlash()
 
         $this->assertSame($expected, $lines);
     }
+
+    public function testProcessBadQuotes()
+    {
+        $lines = [
+            "TEST=\"erert\nTEST='erert\n",
+        ];
+
+        $expected = [
+            "TEST=\"erert\nTEST='erert\n",
+        ];
+
+        $this->assertSame($expected, $lines);
+    }
 }

tests/Dotenv/ParserTest.php

@@ -106,4 +106,40 @@ public function testParserEscapingSingle()
     {
         Parser::parse('FOO_BAD=\'iiiiviiiixiiiiviiii\\a\'');
     }
+
+    /**
+     * @expectedException \Dotenv\Exception\InvalidFileException
+     * @expectedExceptionMessage Failed to parse dotenv file due to a missing closing quote. Failed at ['erert].
+     */
+    public function testMissingClosingSingleQuote()
+    {
+        Parser::parse('TEST=\'erert');
+    }
+
+    /**
+     * @expectedException \Dotenv\Exception\InvalidFileException
+     * @expectedExceptionMessage Failed to parse dotenv file due to a missing closing quote. Failed at ["erert].
+     */
+    public function testMissingClosingDoubleQuote()
+    {
+        Parser::parse('TEST="erert');
+    }
+
+    /**
+     * @expectedException \Dotenv\Exception\InvalidFileException
+     * @expectedExceptionMessage Failed to parse dotenv file due to a missing closing quote. Failed at ["erert].
+     */
+    public function testMissingClosingQuotes()
+    {
+        Parser::parse("TEST=\"erert\nTEST='erert\n");
+    }
+
+    /**
+     * @expectedException \Dotenv\Exception\InvalidFileException
+     * @expectedExceptionMessage Failed to parse dotenv file due to a missing closing quote. Failed at ["\].
+     */
+    public function testMissingClosingQuoteWithEscape()
+    {
+        Parser::parse('TEST="\\');
+    }
 }