Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.3] Rewrite parser and fix escaped quotes in multiline values #322

Merged
merged 1 commit into from
Jan 26, 2019
Merged

[3.3] Rewrite parser and fix escaped quotes in multiline values #322

merged 1 commit into from
Jan 26, 2019

Conversation

GrahamCampbell
Copy link
Collaborator

Closes #319.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@GrahamCampbell GrahamCampbell merged commit 21c540a into vlucas:master Jan 26, 2019
@GrahamCampbell GrahamCampbell deleted the parser-rewrite branch January 26, 2019 16:57
@GrahamCampbell GrahamCampbell changed the title Rewrite parser and fix escaped quotes in multiline values [3.3] Rewrite parser and fix escaped quotes in multiline values Jan 28, 2019
@drzraf
Copy link

drzraf commented Feb 27, 2019

This commit added symfony/polyfill-ctype to composer.json instead php[ctype].
I can't see the rational of this choice. (And I'd rather before off this extra-dependency)

@GrahamCampbell
Copy link
Collaborator Author

This adds the dependency because we are using the ctype functions.

@GrahamCampbell
Copy link
Collaborator Author

The symfony/polyfill-ctype package has ext-ctype as a recommended package. When you install phpdotenv and you don't have the php extension, composer will actually warn you about this, and recommend you install it.

@drzraf
Copy link

drzraf commented Feb 28, 2019

... but if one has php[ctype] it installs an unneeded dependency.

@GrahamCampbell
Copy link
Collaborator Author

You can stop this happening in your app with the following trick. In your app's composer.json, do this:

{
    ...
    "replace": {
        "symfony/polyfill-ctype": "*"
    },
    "require": {
        ...
        "ext-ctype": "*",
        ...
        "vlucas/phpdotenv": "^3.3"
    },
    ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants