Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent using an unhealthy ByoHost #762

Open
maelk opened this issue Jan 3, 2023 · 1 comment
Open

prevent using an unhealthy ByoHost #762

maelk opened this issue Jan 3, 2023 · 1 comment

Comments

@maelk
Copy link

maelk commented Jan 3, 2023

Describe the solution you'd like
A host might, for any reason, become unhealthy, with for example hardware issue or any other problem, while still running the agent. In this case, as a user, I would like a feature allowing me to flag that the ByoHost is temporarily unhealthy and should not be selected by BYOH to deploy a machine, even if the labels match, until I have fixed the issue and removed the flag.

This could be achieved using an unhealthy label on the ByoHost. When present, BYOH would not consider that ByoHost when selecting it.

@dharmjit
Copy link
Contributor

dharmjit commented Jan 6, 2023

Hi @maelk, Thanks for trying out BYOH and raising this issue. We would like to capture more such use cases to improve the host selection logic. Could you elaborate a bit on what you mean by a node is unhealthy but the agent is still running? Is it possible for the agent to detect this unhealthy state so it can be handled in the code?
cc: @shivi28 @Madhur97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants