Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Allow definition of existing secret for Avi configuration #1145

Open
ron1 opened this issue May 10, 2023 · 4 comments
Open
Labels
enhancement New feature or request

Comments

@ron1
Copy link

ron1 commented May 10, 2023

Is your feature request related to a problem? Please describe.

I am unable to use an existing secret generated by a Secrets Manager such as the external-secret operator for the AKO avi-secret.

Describe the solution you'd like

The ako Helm Chart currently captures avicredentials properties and uses them to generate a Secret named avi-secret. In some environments, it is preferred to allow definition of an existing secret rather than the generation of a new secret.

In order to support this case, consider introducing a new Helm property entitled avicredentials.existingSecret. See PR https://github.com/grafana/helm-charts/pull/542/files for a similar feature that was implemented in the Grafana Loki Helm Chart.

Describe alternatives you've considered

No response

Additional context

No response

@ron1 ron1 added the enhancement New feature or request label May 10, 2023
@ron1 ron1 changed the title Allow definition of existing secret for Avi configuration [Feature Request] Allow definition of existing secret for Avi configuration May 22, 2023
@swathinsankaran
Copy link
Member

swathinsankaran commented Jun 29, 2023

@ron1 are you using --generate-name with helm install?

@ron1
Copy link
Author

ron1 commented Jul 6, 2023

@swathinsankaran No.

@swathinsankaran
Copy link
Member

Thanks, @ron1 for the reply.

@itaytalmi
Copy link

Hi, any updates on this? The usage of an existing secret makes a lot of sense. The current state where Helm expects the credentials to be directly specified in the values.yaml imposes a security risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants