Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open-iscsi systemd services broken #1491

Open
szechyjs opened this issue Jun 26, 2023 · 1 comment
Open

open-iscsi systemd services broken #1491

szechyjs opened this issue Jun 26, 2023 · 1 comment
Labels

Comments

@szechyjs
Copy link

Describe the bug

iscsid.service fails load with the following error:
/usr/lib/systemd/system/iscsid.service:13: Neither a valid executable name nor an absolute path: SBINDIR@/iscsid

It seems that open-iscsi/open-iscsi#279 changed it to use @sbindir@, however for whatever reason the sed replace is not working during install.

Also, iscsid now depends on iscsi-init however this unit file is not being installed.

Reproduction steps

  1. tdnf install open-iscsi
  2. systemctl enable iscsid
  3. systemctl start iscsid
    ...

Expected behavior

The service should run

Additional context

No response

@szechyjs szechyjs added the bug label Jun 26, 2023
@dcasota
Copy link
Contributor

dcasota commented Dec 15, 2023

This still is an issue in Ph 5.0. Luckily make build of latest open-iscsi source seems to work flawlessly.

example:

tdnf update -y
tdnf install -y git build-essential

git clone https://<user>:<token>github.com/open-iscsi/open-iscsi
cd ./open-iscsi
tdnf install -y kmod-devel openssl-devel util-linux-devel open-isns-devel systemd-devel
make
make install

systemctl enable iscsid
systemctl start iscsid

# reminder to cleanup all temporary packages installed before if not needed anymore
tdnf remove -y systemd-devel open-isns-devel util-linux-devel openssl-devel kmod-devel build-essential git

gerrit-photon pushed a commit that referenced this issue Dec 20, 2023
Unit files had paths with unresolved @sbindir@ variable.
We must follow upstream behavior and use  install_systemd
to get it resolved.

Change-Id: Iea8303cedb35297e360c1390924af8f35d95a122
Fixes: #1491
Signed-off-by: Alexey Makhalov <alexey.makhalov@broadcom.com>
Reviewed-on: http://photon-jenkins.eng.vmware.com:8082/c/photon/+/22801
Reviewed-by: Tapas Kundu <tkundu@vmware.com>
Tested-by: gerrit-photon <photon-checkins@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants