Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Wiki Rework #172

Closed
Cheezik opened this issue Jan 31, 2024 · 11 comments
Closed

[Feature request] Wiki Rework #172

Cheezik opened this issue Jan 31, 2024 · 11 comments

Comments

@Cheezik
Copy link
Contributor

Cheezik commented Jan 31, 2024

Context

Hello, i am creating much needed wiki rework for this repo (it deserves one)
I am re-styling the whole layout and also updating old/ no longer working code

What are you trying to do and how would you want to do it differently?

Basically Reworking the entire Github wiki

Can you achieve the same result doing it in an alternative way? Is the alternative considerable?

Has the feature been requested before?
No, not to my knowlage.

If the feature request is approved, would you be willing to submit a PR?
Yes.

@vn7n24fzkq
Copy link
Owner

Hi, @Cheezik .

Thank you for your efforts in redesigning the Github wiki for this repository. Your work is greatly appreciated. Regarding your proposal, I am fully supportive and believe it is a great plan to improve the quality and relevance of the wiki. Once your feature request is approved, I will review it promptly and provide feedback. Additionally, I'd like to inform you that I am currently on the Lunar New Year holiday, but I will carefully review your proposal upon my return. Thank you for your patience.

@Cheezik
Copy link
Contributor Author

Cheezik commented Feb 11, 2024

Its all good, i have pretty much finished the rework (link to the fork: https://github.com/Cheezik/github-profile-summary-cards/tree/Wiki-Rework. Branch: Wiki-Rework).

Im planning on adding links under the gifs when i have the time to do so, just let me know anything you'd like to change.

Happy Lunar New year ^^

@vn7n24fzkq
Copy link
Owner

Great! Everything looks fantastic!
Once this rework is finished, I believe we can create a documentation folder for the wiki pages in this repository.
This will allow us to easily manage the wiki page and collaborate by creating new pull requests in the future.
The only thing left for me to do is to write a new GitHub Action CI process to automatically update the wiki Git repository.

This way, your commits and contributions will be visible in this repository. What do you think?

@Cheezik
Copy link
Contributor Author

Cheezik commented Feb 14, 2024

Sounds perfect, i will try to jump onto final changes asap (possibly tomorrow), Once thats done i think its ready

@vn7n24fzkq
Copy link
Owner

Awesome!

@Cheezik
Copy link
Contributor Author

Cheezik commented Feb 21, 2024

Alright, sorry for the masive delay, had some urgent things that had to be done. anyways i think that the fork is ready for PR,
if you have any questions or suggestions just let me know

@vn7n24fzkq
Copy link
Owner

Hi, @Cheezik.

Apologies for the delayed response.
I believe everything is ready now, as I've already added a wiki folder.
Could you please create a merge request and ensure that all the content is placed within the wiki folder?
This way, the wiki pages should be published from the wiki folder. Thank you for your assistance.

@vn7n24fzkq
Copy link
Owner

The PR #175 has been merged.
My apologies for the delay; I've been quite busy lately.
Everything looks fantastic, but it seems like there might be some broken links under the wiki homepage. https://github.com/vn7n24fzkq/github-profile-summary-cards/wiki

Would you mind taking a look? If you need any assistance with fixing them, please don't hesitate to let me know. Thank you for your attention to this matter!

@Cheezik
Copy link
Contributor Author

Cheezik commented Mar 2, 2024

Oh yeah.. i knew this might happen, i will possibly try to solve that today.

@vn7n24fzkq
Copy link
Owner

Hey, @Cheezik. Is this issue finished? If so, I'm going to close it. Thanks again for your hard work.

@Cheezik
Copy link
Contributor Author

Cheezik commented May 24, 2024

yeah im pretty sure the wiki is done, ill try to keep up and check on it if everything works as intended or update the info if anything changes. if there is something let me know ^^

@Cheezik Cheezik closed this as completed May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants