Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request]: Vue Dark theme #69

Open
Mayank0255 opened this issue Oct 29, 2021 · 6 comments
Open

[Feature request]: Vue Dark theme #69

Mayank0255 opened this issue Oct 29, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@Mayank0255
Copy link

I think you should add dark theme variant to vue as well, would look very good

@vn7n24fzkq
Copy link
Owner

vn7n24fzkq commented Oct 31, 2021

Sure, I will add this after I finish #63.

@Mayank0255
Copy link
Author

Sure, I will add this after I finish #63.

Cool, looking forward to it

@iamandrewluca
Copy link

Wouldn't it be better to find a solution that switches to dark/light theme based on GitHub current theme 🤔

https://www.ctrl.blog/entry/svg-embed-dark-mode.html

@Mayank0255
Copy link
Author

Wouldn't it be better to find a solution that switches to dark/light theme based on GitHub current theme 🤔

https://www.ctrl.blog/entry/svg-embed-dark-mode.html

Ya that's a great idea, that can be applicable for the rest of the types of themes as well (github, dracula, etc.)

@vn7n24fzkq
Copy link
Owner

vn7n24fzkq commented Jan 13, 2022

Wouldn't it be better to find a solution that switches to dark/light theme based on GitHub current theme 🤔

https://www.ctrl.blog/entry/svg-embed-dark-mode.html

This would be a good solution to automatic switch theme between dark and light mode.
I think we need to make a sample to make sure that can work with GitHub profile README.

@vn7n24fzkq vn7n24fzkq added the enhancement New feature or request label Jun 30, 2022
@andry81
Copy link

andry81 commented Jul 21, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants