Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions: build docker for PRs from forks #221

Open
vogler opened this issue Sep 22, 2023 · 2 comments
Open

GitHub Actions: build docker for PRs from forks #221

vogler opened this issue Sep 22, 2023 · 2 comments
Labels
docker optimization

Comments

@vogler
Copy link
Owner

vogler commented Sep 22, 2023

Currently, the workflow to build the docker image fails for PRs from forks since they don't have the env vars set to login to Docker Hub:
https://github.com/vogler/free-games-claimer/actions/runs/6270872769/job/17029487465?pr=206
image

For those PRs, it should just build the image and not try to login and push.
Either add a dependant workflow or some conditionals.
@4n4n4s
Copy link
Contributor

4n4n4s commented Sep 27, 2023

Even setting secrets on the fork side let's the build fail see #229. I guess we need to improve it further like you mentioned here in the future.

@4n4n4s
Copy link
Contributor

4n4n4s commented Oct 27, 2023

@vogler I disabled creating docker images in PRs in #229
Please check (also my other PRs 😁)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docker optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vogler @4n4n4s and others