Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all modules replaceable (Due to this issue, the addition of new features in this repository has been suspended.) #533

Open
34j opened this issue Apr 30, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@34j
Copy link
Collaborator

34j commented Apr 30, 2023

Is your feature request related to a problem? Please describe.
Renovate the config file and make all modules replacable or optional

  • Support TTS
  • SSL
  • Vocoder
    • NSF-HifiGan
    • BIGVGan
    • PC-DDSP
  • One shot (so-vits-svc-5.0)
  • NaturalSpeech (so-vits-svc-5.0)
  • F0 Decoder
  • Flow
    • ResidualFlow
    • NanoFlow
    • Flow++?
  • F0 mean filtering
  • top1 search (rvc)
  • (Add HifiSinger, DiffSinger etc.)

Describe the solution you'd like
Someone else will oddly accomplish all of this. Or another repository will accomplish all of this and make this repository unnecessary. It may be a good idea to divide each part into several sub-packages.

Additional context

  • I do not want to do this.
  • There are several huge repositories such as NVidia-nemo, coqui-TTS, espnet, etc., but they are not aimed at audio conversion and unfortunately do not seem to have adapted much of the latest technology within a few months.
@34j 34j added the enhancement New feature or request label Apr 30, 2023
@34j 34j pinned this issue Apr 30, 2023
@34j 34j unpinned this issue Apr 30, 2023
@Kickbub
Copy link

Kickbub commented May 5, 2023

I had this idea as well. In that case will this repo be renamed? Maybe ModularVC or something. Also, I feel like the Fish Diffusion repo may be more suited for this task.

@34j
Copy link
Collaborator Author

34j commented May 5, 2023

Yes, I quite like fish-diffusion in VC related repos, but I couldn't get into their code because I'm a little concerned about some of it. (Feels like they overengineered it.) But I think that is also a good idea.

@34j 34j pinned this issue May 16, 2023
@34j 34j changed the title Make all modules replaceable Make all modules replaceable (Due to this issue, the addition of new features in this repository has been suspended.) Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants