fix(test-utils): allow unknown initialization options and expose locale option
#142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows people to load TypeScript as suggested in #140. Since `initializationOptions` is of type `any` there, it doesn’t really matter. But the `InitializationOptions` interface is used by the test utils and prohibits the user from passing additional properties. Also it’s nice if all Volar based language servers that do allow the client to pass the TypeScript SDK, do so in a consistent manner.
|
Thanks! I modified the API to accept unknown properties. Also corrected is that I think whether to keep |
johnsoncodehk
changed the title
locale option
johnsoncodehk
changed the title
locale optionlocale option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people to load TypeScript as suggested in #140. Since
initializationOptionsis of typeanythere, it doesn’t really matter. But theInitializationOptionsinterface is used by the test utils and prohibits the user from passing additional properties.Also it’s nice if all Volar based language servers that do allow the client to pass the TypeScript SDK, do so in a consistent manner.