Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(language-server): architecture improvements #167

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

johnsoncodehk
Copy link
Member

@johnsoncodehk johnsoncodehk commented Apr 29, 2024

Public Changes

  • Server context is now passed to the ServerProjectProvider via this arg, so the ServerProjectProviderFactory interface is no longer needed.
    • Rename createTypeScriptProjectProviderFactory to createTypeScriptProjectProvider
    • Rename createSimpleProjectProviderFactory to createSimpleProjectProvider
  • initialize method parameters are simplified, getLanguagePlugins and watchFileExtensions are no longer needed.
  • The watchFiles method has been added to replace the old watchFileExtensions option, which will allow file extensions that require watch to be calculated after language plugins are loaded.

For more detailed changes, please refer to the actual type changes.

@johnsoncodehk johnsoncodehk merged commit 665e137 into master Apr 29, 2024
6 checks passed
@johnsoncodehk johnsoncodehk deleted the language-server-2.2 branch April 29, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant