Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in queries/reflect.go in which bind does not check rows.Err() prior to returning sql.ErrNoRows #1324

Open
jonderry opened this issue Nov 10, 2023 · 1 comment
Open

Bug in queries/reflect.go in which bind does not check rows.Err() prior to returning sql.ErrNoRows #1324

jonderry opened this issue Nov 10, 2023 · 1 comment
Labels
help wanted

Comments

@jonderry
Copy link

This can cause sql.ErrNoRows to be returned incorrectly when any error occurs before foundOne is set to true. This danger is documented for Bind, but Query.Bind does not check this. Nor does bind.
@stephenafamo
Copy link
Collaborator

Kindly send in a PR to fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonderry @stephenafamo