Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Platform WiX variable #121

Open
volks73 opened this issue Nov 8, 2020 · 1 comment
Open

Remove the Platform WiX variable #121

volks73 opened this issue Nov 8, 2020 · 1 comment
Assignees

Comments

@volks73
Copy link
Owner

volks73 commented Nov 8, 2020

As discussed in #113, the Platform WiX variable is redundant to the sys.BUILDARCH WiX variable. It is no longer needed in the embedded WXS template. Note, this is the WiX Variable, not to be confused with the Platform attribute of the Product tag of the WXS schema, which is also deprecated.

Some users may have WXS files that depend on the Platform WiX variable. While I want to avoid making more work for users, we cannot be prevented from evolving and fixing inconsistencies that would add to the technical debt of this project. Thus, this issue is to notify users that the variable will eventually be removed.

Note, it is possible to use cargo install --version 0.3.1 cargo-wix to install a specific version of this subcommand that will continue to provide the Platform Wix variable.

The documentation will be updated to indicate the variable is deprecated and its usage should be avoided in new projects, along with a migration example using the sys.BUILDARCH WiX variable.

@volks73
Copy link
Owner Author

volks73 commented Nov 21, 2020

The Platform WiX variable still exists and is available even though #126 and #127 have been resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant