Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rustc configuration output as WiX variables #132

Open
volks73 opened this issue Nov 21, 2020 · 2 comments
Open

Add rustc configuration output as WiX variables #132

volks73 opened this issue Nov 21, 2020 · 2 comments
Assignees

Comments

@volks73
Copy link
Owner

volks73 commented Nov 21, 2020

Similar to #118, there is the output from the rustc --print cfg command that could be passed to the WiX compiler (candle.exe) as WiX variables. See #126 for an example output and an initial discussion on which output would be useful as WiX variables. Relevant comments reposted here:

roblabla@roblabla-work:~/vm-image$ rustc --print cfg --target i686-pc-windows-msvc
debug_assertions
target_arch="x86"
target_endian="little"
target_env="msvc"
target_family="windows"
target_feature="fxsr"
target_feature="sse"
target_feature="sse2"
target_os="windows"
target_pointer_width="32"
target_vendor="pc"
windows

We should add some of these as WiX Variables, too:

  • target_env = TargetEnv
  • target_vendor = TargetVendor

I am not sure the rest are needed or useful.

@volks73
Copy link
Owner Author

volks73 commented Nov 21, 2020

Any listed target_feature might be useful as well, i.e. crt-static (#115). I guess each one would become TargetFeature<NAME>. If set, then it will be defined. If not set or present in the output, then it will not be set. The ifdef preprocessor directive could be used by developers in the WXS files to toggle installer features based on target features.

@volks73
Copy link
Owner Author

volks73 commented Nov 21, 2020

As of 8448e17, the TargetEnv and TargetVendor WiX variables are available at least.

The TargetFeature<NAME> variables are still a work-in-progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant