Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --manifest-path option to all sub-commands #160

Open
volks73 opened this issue Jan 22, 2022 · 0 comments
Open

Add --manifest-path option to all sub-commands #160

volks73 opened this issue Jan 22, 2022 · 0 comments
Assignees

Comments

@volks73
Copy link
Owner

volks73 commented Jan 22, 2022

In keeping with the CLI for cargo, there is the --manifest-path <PATH> option to specify the path to a manifest file, Cargo.toml. The default is to use the Cargo.toml file in the current working directory and error if one is not found. This option would allow the user to execute cargo wix commands for a project from outside the current working directory.

Additionally, the <INPUT> argument is currently a path to a manifest file for many of the subcommands. There was a unification effort a while back to make sure the <INPUT> was consistent across all subcommands (#70). This might be a back-track on that effort, but each subcommand appear to need different input. For example, the cargo wix command could use the <INPUT> argument to use multiple WXS files instead of the -I,--include (#92), while the cargo wix sign command could use the <INPUT> argument to be a path to one or more created installers (msi) to sign. The <INPUT> argument name would change to be more descriptive for the specific subcommand. However, every subcommand pretty much needs the Cargo.toml file. This was the reason for using the <INPUT> argument originally. Now with configuration within the Cargo.toml file through package metadata, it might be better to have an explicit option to define a path to a Cargo.toml file instead of trying to make <INPUT> do magic or serve multiple meanings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant