package.metadata.wix.product-name doesn't work

[nazar-pc]

Setting it in Cargo.toml has no effect, only CLI option works right now.

I think some fallback like this is necessary for product-name:

cargo-wix/src/print/wxs.rs

Line 699 in 0a88f0c

.and_then(|t| t.get("product-icon"))

[volks73]

Thank you for the issue. This is most likely a bug, either in the documentation for suggesting this is an implemented key or in the implementation for supporting the key if it is implemented. Would be able to submit a PR to resolve this issue?

[volks73]

I have looked into this just briefly, and the product-name field is not supported. This is because the product name is taken from the name field for the package:

cargo-wix/src/lib.rs

Line 217 in 0a88f0c

fn product_name(product_name: Option<&String>, manifest: &Package) -> String {

[package]
name = "product-name-here"

There is the --product-name CLI option that can be used to override and/or explicitly define the product name, but there is no product-name field under the [package.metadata.wix] section.

[nazar-pc]

I see, I somehow completely missed that and assumed it was symmetrical. Do you think it would make sense to support that though? It is interesting that name and product-icon can be changed that way, but product-name can't.