Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: base on @typescript-eslint #135

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat!: base on @typescript-eslint #135

wants to merge 10 commits into from

Conversation

voxpelli
Copy link
Owner

@voxpelli voxpelli commented Sep 13, 2022

Fixes #73

@voxpelli
Copy link
Owner Author

voxpelli commented Jul 4, 2023

Possibly alternative target:

Publish an optional extra that targets just *.d.ts files and not .js files, as Types in JS projects otherwise will get no linting on their *.d.ts files.

Though: If one will anyway pull in @typescript/eslint then why not use it for all the files?

I guess flat configs makes this easier as @typescript/eslint doesn't have to be a peer dependency anymore? Assuming that it has been updated to work with flat-config that is.

Had to add skipLibCheck as a temporary fix for typescript-eslint/typescript-eslint#6307

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@voxpelli voxpelli changed the title Evaluate @typescript-eslint feat!: base on @typescript-eslint Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly start using @typescript-eslint
1 participant