Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systemd service stop issues with multiple redis instances #386

Open
radarnex opened this issue Jan 20, 2021 · 1 comment
Open

Systemd service stop issues with multiple redis instances #386

radarnex opened this issue Jan 20, 2021 · 1 comment

Comments

@radarnex
Copy link

radarnex commented Jan 20, 2021

Affected Puppet, Ruby, OS and module versions/distributions

  • Distribution: Ubuntu
  • Module version: 6.19.0

How to reproduce (e.g Puppet code you use)

Service template contains the parameter RuntimeDirectory which tells systemd to delete the dir when stopped. It was introduced more than 1 year ago (8749ce7).

If you use multiple redis instances it can cause issues if you stop one of the instances (it'll delete all sockets and pid files inside the dir). In that case, you need to stop all instances and start them again at the same time, otherwise, it'll not work (kind of race condition).

My suggestion would be to add the parameter RuntimeDirectoryPreserve=yes to the service template. The only drawback is that when you stop the service the runtime folder /var/run/redis will not be deleted.

@root-expert
Copy link
Member

I think this is fixed by b7f7478
Can you confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants