rdb_save_incremental_fsync cannot be turned off

[thejambavan]

Affected Puppet, Ruby, OS and module versions/distributions

• Puppet: 7.26.0
• Ruby: ruby 2.7.8p225 (2023-03-30 revision 1f4d455848) [x86_64-linux]
• Distribution: Ubuntu 22.04.3
• Module version: 9.2.0 and master

How to reproduce (e.g Puppet code you use)

1. Include the redis module:

include redis

3. Add required heiradata to disable rdb_save_incremental_fsync

redis::rdb_save_incremental_fsync: false

What are you seeing

When rdb_save_incremental_fsync is set to false, redis should not use rdb-save-incremental-fsync. The CLI shows that it is still enabled:

$ redis-cli
127.0.0.1:6379> config get rdb-save-incremental-fsync
1) "rdb-save-incremental-fsync"
2) "yes"

The relevant config also does not appear in redis.conf:

# When redis saves RDB file, if the following option is enabled
# the file will be fsync-ed every 32 MB of data generated. This is useful
# in order to commit the file to the disk more incrementally and avoid
# big latency spikes.
<blank line where i would expect to see "rdb-save-incremental-fsync no">

What behaviour did you expect instead

the line:

rdb-save-incremental-fsync no

to appear in redis.conf when rdb-save-incremental-fsync is false or undef

the line

rdb-save-incremental-fsync yes

to appear in redis.conf when rdb-save-incremental-fsync is true

Output log

n/a

Any additional information you'd like to impart

I believe this to be happening due to the assumption that rdb-save-incremental-fsync is off by default. I have a PR to fix this that'll be along momentarily.