Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSDL: pass error from parsing XML as-is, not only its message #1022

Merged
merged 1 commit into from Feb 11, 2019

Conversation

peat-psuwit
Copy link
Contributor

By passing only error's message, callee losses information about stack,
which is helpful in debugging. Besides, passing string as error breaks
mocha. (See mochajs/mocha#3320)

P.S.: I'm not sure if I should add the test to "should catch parse error" above instead of separating to its own test or not because the content of the new test is essentially copy-pasted from the above test.

By passing only error's message, callee losses information about stack,
which is helpful in debugging. Besides, passing string as error breaks
mocha. (See mochajs/mocha#3320)
@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.364% when pulling ac40cb4 on peat-psuwit:wsdl-pass-parse-error-as-is into 0efafa2 on vpulim:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants