Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed PasswordDigest Generation #1039

Merged
merged 5 commits into from Feb 13, 2019
Merged

Fixed PasswordDigest Generation #1039

merged 5 commits into from Feb 13, 2019

Conversation

martinholden-skillsoft
Copy link
Contributor

The WSSE password digest is best calculated from a byte array of the concat of NONCE, CREATED TIMESTAMP and PASSWORD

The WSSE password digest is best calculated from a byte array of the concat of NONCE, CREATED TIMESTAMP and PASSWORD
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 93.156% when pulling be0fbcd on martinholden-skillsoft:master into 9541e14 on vpulim:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 93.156% when pulling be0fbcd on martinholden-skillsoft:master into 9541e14 on vpulim:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 93.156% when pulling be0fbcd on martinholden-skillsoft:master into 9541e14 on vpulim:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 93.156% when pulling be0fbcd on martinholden-skillsoft:master into 9541e14 on vpulim:master.

@coveralls
Copy link

coveralls commented Jan 9, 2019

Coverage Status

Coverage increased (+0.2%) to 93.5% when pulling 75e7f91 on martinholden-skillsoft:master into 63bd7b7 on vpulim:master.

@jsdevel
Copy link
Collaborator

jsdevel commented Feb 11, 2019

please provide tests and fix the build

@jsdevel
Copy link
Collaborator

jsdevel commented Feb 12, 2019

Please fix the build

@martinholden-skillsoft
Copy link
Contributor Author

Please fix the build

I am not sure what you want me to fix, none of the issues appear to be in any of the files I have touched

@jsdevel
Copy link
Collaborator

jsdevel commented Feb 12, 2019

have you rebased your branch onto master?

@martinholden-skillsoft
Copy link
Contributor Author

have you rebased your branch onto master?

Yes, just did it again now and no changes. The Travis build is reporting an error in code I haven't touched on Node 6

1 failing

  1. SOAP Server
    should properly handle compression:
    Uncaught AssertionError: false == true
    • expected - actual
      -false
      +true

Refactored to ensure the server is running before the test runs
@martinholden-skillsoft
Copy link
Contributor Author

have you rebased your branch onto master?

Yes, just did it again now and no changes. The Travis build is reporting an error in code I haven't touched on Node 6

1 failing

  1. SOAP Server
    should properly handle compression:
    Uncaught AssertionError: false == true

    • expected - actual
      -false
      +true

I refactored the failing test for the compression check that wasnt mine :-)

Porting to the Buffer.from()
@jsdevel jsdevel merged commit f4fd1e7 into vpulim:master Feb 13, 2019
@jsdevel
Copy link
Collaborator

jsdevel commented Feb 13, 2019

thanks @martinholden-skillsoft !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants