Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wsdl): array namespace override with colon(:) #1045

Merged
merged 1 commit into from Feb 20, 2019

Conversation

RishikeshDarandale
Copy link
Contributor

Description

Currently, the colon override(:) for array attribute is not preserved and thus
by default the parent namespace or override provided namespace is used for array
attribute.

To handle this scenario/edge case, colon(:) is preserved for array attribute as
well. :array will not have any namespace as normal attribute.

example

const input = {
  ':array': [
     {
        someAttribute: 'desc1'
     },
     {
       someAttribute: 'desc2'
     },
  ]
}

In above example array attribute will not prefixed with parent namespace.

@RishikeshDarandale
Copy link
Contributor Author

@jsdevel , Can you please help in why coveralls command failed? Thanks!

@coveralls
Copy link

coveralls commented Feb 20, 2019

Coverage Status

Coverage increased (+0.03%) to 93.727% when pulling 8774011 on RishikeshDarandale:topics/array-namespace into 9aed566 on vpulim:master.

Currently, the colon override(:) for array attribute is not preserved and thus
by default the parent namespace or override provided namespace is used for array
attribute.

To handle this scenario/edge case, colon(:) is preserved for array attribute as
well. `:array` will not have any namespace as normal attribute.
@RishikeshDarandale
Copy link
Contributor Author

RishikeshDarandale commented Feb 20, 2019

@jsdevel , this is now rebased with master and build is also happy 😃

Also, increased the timeout to 15000 as travis build was failing.

@jsdevel jsdevel merged commit adb0739 into vpulim:master Feb 20, 2019
@RishikeshDarandale RishikeshDarandale deleted the topics/array-namespace branch February 20, 2019 05:25
@RishikeshDarandale
Copy link
Contributor Author

@jsdevel Thanks for quick review and merge. When you are planning a new release/publish?

@jsdevel
Copy link
Collaborator

jsdevel commented Feb 20, 2019

Maybe in a week

@RishikeshDarandale
Copy link
Contributor Author

Maybe in a week

Any luck to release/publich a new version?

@RishikeshDarandale
Copy link
Contributor Author

@jsdevel , Any tentative date for a release? We need this one for our production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants