New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding source-map-support for ts mapping in stack trace; enabling tsl… #1047
Conversation
How about using husky for linting and formatting at the time of commit? |
I haven't used husky. I'll check it out. |
I added husky and lint-staged to do a partial lint of staged files on commit. If there are linting errors it will attempt to fix what it can or fail to commit if the errors cannot be automatically fixed. |
Absolutely no husky sorry. Please remove that. |
package.json
Outdated
@@ -60,13 +75,16 @@ | |||
"express": "^4.16.4", | |||
"finalhandler": "^1.1.1", | |||
"glob": "^7.1.3", | |||
"husky": "^1.3.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove husky
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsdevel , any particular reason to remove husky
?
husky is gone. |
Thanks. In a publicly shared repo, I'd like to limit what runs on my machine when making contributions. |
…int rules; added linting to travis; removing unnecessary self variables
I just went through and removed all unnecessary |
well, that's not good. I'm a little confused by the coverage results. |
I think it's just because of the removed |
i can accept the coverage decrease. thanks @andygreenegrass ! |
…int rules; added linting to travis
I added the source-map-support dev dependency which will resolve ts file and line numbers in stack traces during the tests.
I enabled some of the previously disabled tslint rules and made the updates to fix those.
I also added linting to travis.