Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding source-map-support for ts mapping in stack trace; enabling tsl… #1047

Merged
merged 1 commit into from Feb 21, 2019
Merged

adding source-map-support for ts mapping in stack trace; enabling tsl… #1047

merged 1 commit into from Feb 21, 2019

Conversation

andygreenegrass
Copy link
Contributor

…int rules; added linting to travis

I added the source-map-support dev dependency which will resolve ts file and line numbers in stack traces during the tests.
I enabled some of the previously disabled tslint rules and made the updates to fix those.
I also added linting to travis.

@coveralls
Copy link

coveralls commented Feb 21, 2019

Coverage Status

Coverage decreased (-0.02%) to 93.705% when pulling 7b2fba6 on andygreenegrass:master into adb0739 on vpulim:master.

@RishikeshDarandale
Copy link
Contributor

How about using husky for linting and formatting at the time of commit?

@andygreenegrass
Copy link
Contributor Author

andygreenegrass commented Feb 21, 2019

I haven't used husky. I'll check it out.

@andygreenegrass
Copy link
Contributor Author

andygreenegrass commented Feb 21, 2019

I added husky and lint-staged to do a partial lint of staged files on commit. If there are linting errors it will attempt to fix what it can or fail to commit if the errors cannot be automatically fixed.

@jsdevel
Copy link
Collaborator

jsdevel commented Feb 21, 2019

Absolutely no husky sorry. Please remove that.

package.json Outdated
@@ -60,13 +75,16 @@
"express": "^4.16.4",
"finalhandler": "^1.1.1",
"glob": "^7.1.3",
"husky": "^1.3.1",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove husky

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jsdevel , any particular reason to remove husky?

@andygreenegrass
Copy link
Contributor Author

husky is gone.

@jsdevel
Copy link
Collaborator

jsdevel commented Feb 21, 2019

Thanks. In a publicly shared repo, I'd like to limit what runs on my machine when making contributions.

…int rules; added linting to travis; removing unnecessary self variables
@andygreenegrass
Copy link
Contributor Author

I just went through and removed all unnecessary self variables. I wanted to get that in there along with the move to arrow functions. There will be no more changes for this pull request.

@andygreenegrass
Copy link
Contributor Author

well, that's not good. I'm a little confused by the coverage results.

@andygreenegrass
Copy link
Contributor Author

I think it's just because of the removed const self = this; lines.

@jsdevel
Copy link
Collaborator

jsdevel commented Feb 21, 2019

i can accept the coverage decrease. thanks @andygreenegrass !

@jsdevel jsdevel merged commit 9cb3bf0 into vpulim:master Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants